Repository navigation
apko-plan: support multiple apko configs per image - #58
Merged
Merged
Conversation
Fan out one apko publish leg per config listed in an image's apko_configs (default: [apko/<service>.yaml], so existing catalogs are unchanged). The image tag suffix is derived from the config filename stem (apko/<svc>-<suffix>.yaml -> -<suffix>) and passed with the config path to apko-publish, which appends the suffix to both the SHA and publish tags. Smoke tests run for the default config only. Melange build legs are keyed on needs_melange and unaffected: extra apko configs reuse the same prebuilt APKs, they do not fork the build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Let an image in the apko catalog declare
apko_configs— a list of apko YAML files to build for that image. The plan fans out one apko publish leg per config (default[apko/<service>.yaml], so existing catalogs are unchanged).The image tag suffix is derived from the config filename stem (
apko/<svc>-<suffix>.yaml→-<suffix>) and passed with the config path toapko-publish, which appends it to both the SHA and publish tags. Smoke tests run for the default config only.Safety
apko_configs⇒ identical to today's single-config behaviour.needs_melangeand unaffected — extra apko configs reuse the same prebuilt APKs, they don't fork the build.Tests
apko-plan.test.shgains variant-fan-out coverage: one row per config, filename-derived suffix, default-only smoke, single melange leg.