Repository navigation
Conversation
joshklop
marked this pull request as ready for review
September 29, 2026 19:42
joshklop
added this pull request to stack #23089
September 29, 2026 19:42
Remove the dedicated eth_getProof metrics in favor of Reth RPC server metrics. BREAKING CHANGE: Historical-proofs operators must migrate dashboards from reth_optimism_rpc_eth_api_ext_get_proof_* to reth_rpc_server_calls_* filtered by method="eth_getProof". Per-entry batch outcomes and latency, authenticated RPC calls, and standalone notifications are no longer measured.
joshklop
force-pushed
the
joshklop/use-reth-proof-rpc-metrics
branch
from
September 29, 2026 20:05
a6eb07d to
febe2cb
Compare
Contributor
Author
|
Closing in favour of tracking this as ethereum-optimism/protocol-team#455, to keep it out of the reth v2.6.0 stack. The branch is kept for reference. |
An error occurred while trying to automatically change base from
joshklop/update-reth-v2.6.0
to
develop
October 16, 2026 12:21
An error occurred while trying to automatically change base from
joshklop/update-reth-v2.6.0
to
develop
October 16, 2026 12:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #23046. The historical-proofs override currently duplicates Reth's built-in per-method RPC instrumentation, so this switches operators to the standard
reth_rpc_server_calls_*{method="eth_getProof"}series and documents the migration and its accounting differences.This intentionally accepts that Reth exposes only volume for batch entries and does not cover authenticated RPC calls or standalone notifications. The in-tree Kona hosts, Go clients, and proof benchmark all issue individual
eth_getProofcalls rather than JSON-RPC batches.A seven-day comparison of successful-call counter increases found an exact match on production proof nodes and differences of only -0.0014% to -0.0078% on high-volume I nodes. This query reports the percentage difference per network and namespace, where zero means the counters are equivalent:
Known rollout dependency: the Grafana dashboard
op-reth: NVMe vs hyperdiskhas five queries across its proof-serving panels that use the removed metrics. Those queries must be migrated before this change is deployed.No additional integration test is included because the metric middleware and batch accounting are owned and tested upstream; the local change only removes handler-level instrumentation, while the operator documentation captures the pinned upstream semantics.
BREAKING CHANGE: Historical-proofs operators must migrate dashboards and alerts from
reth_optimism_rpc_eth_api_ext_get_proof_*toreth_rpc_server_calls_*filtered bymethod="eth_getProof". The publicEthApiExtMetricsRust type is removed. Per-entry batch outcomes and latency, authenticated RPC calls, and standalone notification calls are no longer measured.