Repository navigation
ci: build kona-zkvm-canary in its own melange stack - #23288
Merged
Merged
Conversation
kona-zkvm-canary was an op-stack-rust subpackage, but its SP1 profiling feature keeps it out of the combined cargo build, so it already ran a second cargo invocation with its own target tree. That shared nothing with the main build yet ran after it: a second fat-LTO link of kona-host + SP1 on every op-stack-rust leg (22m42s aarch64 / 14m09s x86_64 on develop run 37809128424). Every image depending on op-stack-rust, including kona-node, kona-host and kona-client releases, waited for it. Give the canary its own melange stack with the same runner profile and GHA cache settings, so it builds in parallel and op-stack-rust tags no longer build it at all. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
geoknee
marked this pull request as ready for review
October 9, 2026 09:54
Inphi
approved these changes
Oct 9, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Oct 9, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
kona-zkvm-canarywas a subpackage ofmelange/op-stack-rust.yaml. Its SP1 profiling feature has to stay out of the combined build, so it already ran its owncargo buildwith its own target tree (rust_kona_sp1_crates_zkvm-canary). It shared nothing with the main build, but melange runs subpackage pipelines after the main pipeline. So everyop-stack-rustleg paid for two fat-LTO builds back to back.Develop run 37809128424:
Every image built from
op-stack-rustwaited for it, includingkona-node/v*,kona-host/v*andkona-client/v*release tags.Change
melange/kona-zkvm-canary.yaml, the same build step moved verbatim: same build environment,install-dir, modroot, profile and strip.kona-zkvm-canarysubpackage is removed fromop-stack-rust.yaml.images.apko.json, a newkona-zkvm-canarymelange stack (largerunner, GHA cache keyed onrust/Cargo.lock), and the canary image nowneeds_melange: ["kona-zkvm-canary"].The factory
apko-planscript (pinned shab71bfb2), run locally against this catalog, gives:kona-zkvm-canary/{x86_64,aarch64}legs. kona-node, kona-host, kona-client and op-challenger still depend onop-stack-rustonly.kona-node/v1.8.0-rc.3tag: melange builds onlyop-stack-rust, with no canary.kona-zkvm-canary/v0.2.0tag: only the canary stack, withbuild_version=v0.2.0.Expected effect
apkojob still waits for the whole melange matrix, so the canary leg runs in parallel rather than vanishing.op-stack-rustrelease tags skip the canary entirely.largerunner jobs per rust build. The canary's target tree moves out of theop-stack-rustcache into its own cache entry;CARGO_HOMEis now duplicated across the two.Caveats for review
maxperfbuild of kona-host + SP1. Theop-stack-rustcache still restores, minus the canary tree it no longer needs..github/images.apko.json, ashared_pathsentry, so CI here plans the full catalog. That exercises the new stack end to end onfast-build.🤖 Generated with Claude Code