Repository navigation
op-node: tolerate pruned L1 history in genesis check - #23331
Open
Tyagiquamar wants to merge 1 commit into
Open
Tyagiquamar wants to merge 1 commit into
Tyagiquamar wants to merge 1 commit into
Conversation
When reth --minimal prunes the rollup L1 genesis block, CheckL1GenesisBlockHash now skips validation using the same history-pruned RPC error path as the L2 check. Fixes ethereum-optimism#23161
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CheckL1GenesisBlockHash, matching the existing L2 genesis check.Fixes #23161
Test plan
golang:1.26-bookwormfrom repo root:go test -count=1 -run TestCheckL1BlockRefByNumber ./op-node/rollup/ -v(pass, 1.430s)golang:1.26-bookworm:gofmt -lon changed files (clean)