Add partner assets and register integrations - #417
Conversation
Add three partner logo assets (ensnode.jpg, thurinidentitykit.jpg, dmpayipfs.jpg) and register them in INTEGRATIONS. Imports for ENSNode, ThurinIdentityKit, and DMPayIPFS were added to src/lib/constants/integrations.ts, and corresponding entries (name, url, logo) were appended to the integrations array so these partners appear in the app.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis PR adds three new partner logo assets and registers ENSNode, Thurin Identity Kit SDK, and DMPay IPFS as integrations in the
Confidence Score: 4/5Safe to merge after resolving the dual DMPay entries; the ENSNode and Thurin additions are clean. The ENSNode and Thurin Identity Kit additions are straightforward and correct. The DMPay IPFS entry introduces two concerns: users will see the same brand listed twice in the integrations UI, and the eth.link gateway URL can go offline independently of the partner. Neither blocks functionality outright, but they are visible to end users and worth addressing before merging. src/lib/constants/integrations.ts — specifically the new DMPay IPFS entry and its relationship to the pre-existing dmpay entry. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[integrations.ts] --> B[INTEGRATIONS array]
B --> C[ENSNode\nhttps://ensnode.io/]
B --> D[Thurin Identity Kit SDK\nhttps://docs.thurin.id/]
B --> E[DMPay IPFS\nhttps://dmpay.eth.link/]
B --> F[dmpay — existing\nhttps://app.dmpay.me/]
C --> G[public/assets/partners/ensnode.jpg]
D --> H[public/assets/partners/thurinidentitykit.jpg]
E --> I[public/assets/partners/dmpayipfs.jpg]
E -.->|same brand| F
style E fill:#ffe0b2,stroke:#e65100
style F fill:#ffe0b2,stroke:#e65100
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[integrations.ts] --> B[INTEGRATIONS array]
B --> C[ENSNode\nhttps://ensnode.io/]
B --> D[Thurin Identity Kit SDK\nhttps://docs.thurin.id/]
B --> E[DMPay IPFS\nhttps://dmpay.eth.link/]
B --> F[dmpay — existing\nhttps://app.dmpay.me/]
C --> G[public/assets/partners/ensnode.jpg]
D --> H[public/assets/partners/thurinidentitykit.jpg]
E --> I[public/assets/partners/dmpayipfs.jpg]
E -.->|same brand| F
style E fill:#ffe0b2,stroke:#e65100
style F fill:#ffe0b2,stroke:#e65100
Reviews (1): Last reviewed commit: "Add partner assets and register integrat..." | Re-trigger Greptile |
| { | ||
| name: 'DMPay IPFS', | ||
| url: 'https://dmpay.eth.link/', | ||
| logo: DMPayIPFS, | ||
| }, |
There was a problem hiding this comment.
Duplicate DMPay brand in integrations list
An existing dmpay entry (line 510–513) already points to https://app.dmpay.me/. The new DMPay IPFS entry points to https://dmpay.eth.link/, which is just the same brand's app served through an ENS IPFS gateway. Users browsing the integrations list will see DMPay listed twice, likely with different logos, which is confusing. If the intent is to highlight the decentralized IPFS deployment specifically, a clarifying note in the name (e.g. "dmpay (IPFS)") or a description field would help; if the same user-facing product is meant, consider consolidating to a single entry.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
same brand different product
There was a problem hiding this comment.
Got it — if they're distinct products under the same brand, two separate entries makes complete sense. I'll withdraw that concern.
Shall I remember this as a rule: "allow multiple entries for the same brand in INTEGRATIONS when they represent distinct products"?
Tip: You can customize Greptile's behavior for this repo with .greptile/rules.md and .greptile/config.json.
| name: 'DMPay IPFS', | ||
| url: 'https://dmpay.eth.link/', | ||
| logo: DMPayIPFS, |
There was a problem hiding this comment.
eth.link gateway reliability concern for DMPay IPFS URL
https://dmpay.eth.link/ routes through the eth.link ENS-to-IPFS gateway operated by ENS Labs. This third-party gateway has experienced outages in the past, meaning the link could appear broken to users independently of the partner's actual availability. If the partner has a stable centralized URL (like the existing https://app.dmpay.me/), that would be more reliable for an integrations listing.
Add three partner logo assets (ensnode.jpg, thurinidentitykit.jpg, dmpayipfs.jpg) and register them in INTEGRATIONS. Imports for ENSNode, ThurinIdentityKit, and DMPayIPFS were added to src/lib/constants/integrations.ts, and corresponding entries (name, url, logo) were appended to the integrations array so these partners appear in the app.