add runtime dependency in python dsl codon jit setup#810
Open
BI71317 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #808
After adding the dependency
Installing
codon-jitwith pip now also installs the CPython NumPy package.The output above was produced from my local Codon checkout, installed in editable mode from:
MRE
This MRE is slightly different from the one in #808.
It checks both the regular CPython NumPy path and the Codon JIT NumPy path in the same script.
Result
The script now runs successfully after installing
codon-jit, becausepython NumPyis installed as a dependency.This confirms that the JIT package can import the CPython NumPy module when it initializes the Python-side decorator logic,
while the NumPy import inside the JIT-compiled function body is still handled as Codon-NumPy.