Migrate rocket info gui to scenario and fix for Space Age#420
Open
bbassie wants to merge 2 commits into
Open
Conversation
Port modules/gui/rocket-info into exp_scenario/gui/rocket_info using the new exp_gui element API, matching the other scenario guis. The per-force stats, launch times and silo tracking from the legacy control module are folded into the gui module. - Drop the removed auto/remote launch controls and count launches via on_cargo_pod_finished_ascending instead of the old launch event - Add the exp-gui_rocket-info locale section - Disable the legacy module in the file loader and re-enable the gui/rocket-info role permission Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Address review feedback: store the per-force rocket stats, launch times and silos on the container's force data instead of a separate storage registration, and rebuild the stats, milestone and progress tables with add_row/refresh_row helpers that update label references in place. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the rocket info gui out of
exp_legacyinto the modernexp_scenariomodule and fixes it for Factorio 2.0 / Space Age.exp_scenario/module/gui/rocket_info.luabuilt on the currentexp_guielement API, matching the style of the other scenario guis (autofill, research_milestones, player_stats). The per-force stats, launch times and silo tracking from the legacymodules/control/rocketsare folded into the gui module.auto_launchwas removed from the 2.0 api) and count launches viaon_cargo_pod_finished_ascendinginstead of the old launch event. Build progress still usesrocket_parts/waiting_to_launch_rocket.exp-gui_rocket-infolocale section toexp_scenario/module/locale/en.cfg.gui/rocket-inforole permission.Notes
exp_legacy/.../modules/gui/rocket-info.luaand.../modules/control/rockets.lua) are left in place but disabled via the file loader.Testing
🤖 Generated with Claude Code