Conversation
gwdp
force-pushed
the
gwdp/ss2-socket-auth-docs
branch
from
September 17, 2026 19:00
6abe6ae to
ee3c2aa
Compare
gwdp
force-pushed
the
gwdp/ss3-drop-metrics-cors-flag
branch
from
September 17, 2026 19:00
aa60f88 to
78cfc43
Compare
gwdp
changed the title
This was referenced Sep 17, 2026
gwdp
force-pushed
the
gwdp/ss2-socket-auth-docs
branch
from
September 17, 2026 23:56
ee3c2aa to
d2eede7
Compare
gwdp
force-pushed
the
gwdp/ss3-drop-metrics-cors-flag
branch
2 times, most recently
from
September 18, 2026 16:09
718c042 to
56579b7
Compare
gwdp
marked this pull request as ready for review
September 18, 2026 17:11
gwdp
force-pushed
the
gwdp/ss2-socket-auth-docs
branch
from
September 21, 2026 18:43
6d6e458 to
cdc3970
Compare
gwdp
force-pushed
the
gwdp/ss3-drop-metrics-cors-flag
branch
from
September 21, 2026 18:43
56579b7 to
1b7b0b5
Compare
gwdp
force-pushed
the
gwdp/ss2-socket-auth-docs
branch
from
September 22, 2026 00:13
cdc3970 to
21d0471
Compare
gwdp
force-pushed
the
gwdp/ss3-drop-metrics-cors-flag
branch
from
September 22, 2026 00:13
1b7b0b5 to
60621a3
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
--metrics-cors-originwas the narrow flag: it only opened/metrics. Now that--cors-origincovers every route, the two flags mean the same thing, and the CLI just merges them.eas-cli will stop passing the old flag once expo/eas-cli#4437 is merged
How
Remove the
--metrics-cors-originCLI flag andmetricsCorsOriginson middlewareTest Plan
CI + confirm EAS no longer send this before merging