Conversation
A fragment is never sent, so a shared link no longer puts the token in a request line, a proxy log, or a link unfurler's fetch. The 401 page hands it over as the query the gate reads, and the client clears it from the address bar on a visit that already holds the cookie. The query form is unchanged, so the preview page keeps passing it to the framed preview.
gwdp
force-pushed
the
gwdp/require-token-401-page
branch
from
September 21, 2026 19:04
303c2bd to
b4709d3
Compare
gwdp
force-pushed
the
gwdp/share-token-in-fragment
branch
from
September 21, 2026 19:04
3d94dc0 to
a370ae7
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A shared link carried the token as
?token=, so it reached the tunnel's access logs, any proxy in front of it, and any chat app that unfurled the link. That token opens a route that runs shell commands on the host.How
Stacked on #165. x-ref expo/eas-cli#4434.
Test Plan
/#token=…sends no token on the first request, loads the preview, and leaves a clean address bar