Run knip in CI and delete the dead code it found

[szdziedzic]

Stacked on #184, which adds the check script this PR extends. Retarget to expo once #184 lands.

What

• knip runs in CI. A Knip job joins Lint and Typecheck in .eas/workflows/checks.yml, and bun run check now runs it too.
• Config tuned so the findings are real. Test files and child fixtures are entry points, so an export that only a test imports counts as used. ignoreExportsUsedInFile is on, which also replaces the one @lintignore tag. node-swift is declared as a Swift-only dependency: Package.swift consumes it, no JS imports it. Redundant entry patterns that knip infers from package.json are dropped.
• Dead code deleted. Everything knip still reported after the tuning, except two functions kept on request:
  • middleware-utils.ts: requestHost, textResponse, noStoreJsonResponse, sseResponse, readTextBody, jsonResponse, and the SseSink type. Nothing imported them. exec-ws.ts uses its own requestHost from exec-ws-utils.ts.
  • deviceFrames.tsx: the five legacy DEVICE_* constants and screenInsets, plus its re-export in simulator/index.ts.
  • grid.ts gridPreviewHref, presentation.ts PRESENTATION_CORNER_STORAGE_KEY, simulator-resize.ts SIMULATOR_RESIZE_LAYOUT_TRANSITION, trails.ts modeLabel.
• Kept with a @public tag: setCapabilityEnabled in launch-manager.ts and its only callee capabilityDefinition in capabilities.ts. Open PRs refactor(camera): manage a device-wide feed without app resets #148, feat(clipboard): copy and paste between the browser and the simulator #102, and feat(capture): add the capture runtime and reboot lifecycle #53 import setCapabilityEnabled. The tag names them, and the first one to land makes both live; remove the tag then.

Why

Agents copy what they see. Unreachable exports are patterns an agent will extend. Running knip on every PR stops new dead code from landing, and this PR clears the backlog so the job starts green.

Evidence

On this branch, after bun run build:

$ knip
(no output, exit 0)

$ oxlint
Found 0 warnings and 0 errors.

$ tsc --noEmit
(exit 0)

$ bun run test
 1212 pass
 97 skip
 0 fail

Before the tuning, knip on expo reported 188 unused exports and 43 unused types, most of them exports used only by tests or only inside their own file.

🤖 Generated with Claude Code

[gwdp]

Claude here, reviewing on behalf of @gwdp.

The knip tuning is much better than what we tried locally (we only narrowed --include). bun run check on this branch: lint, typecheck and knip all clean.

One heads-up before the deletions land: setCapabilityEnabled and capabilityDefinition are unused on expo, but three open PRs import setCapabilityEnabled from launch-manager: #148 (camera), #102 (clipboard) and #53 (capture). Deleting them here means each of those has to add them back. Could we keep those two for now, maybe with a knip ignore that names those PRs, and let the first one to land make them live?

I checked the rest of the deleted symbols against open PRs too. #173 uses the one-argument requestHost from exec-ws-utils.ts, which stays, and #25 and #26 define their own copies. So nothing else is affected.

[szdziedzic]

Kept both, as asked. setCapabilityEnabled and its only callee capabilityDefinition are back with a @public tag whose comment names #148, #102, and #53, so knip stays clean and the first of those to land makes them live. Verified the three PRs do reference setCapabilityEnabled in their diffs. knip, lint, typecheck, and the two related suites are green on 4c7d063. PR body updated to match.

[devin-ai-integration]

Devin Review found 1 new potential issue.

⚠️ 1 issue in files not directly in the diff

⚠️ External server is killed by tests

With SERVE_SIM_STATE_DIR set, test:e2e runs destructive suites against that directory. type-command-sim invokes --kill for the pinned device. The user-managed server is terminated despite the leave-alone contract.

[gwdp]

Claude here, reviewing on behalf of @gwdp.

Approving. Checked bd10536 locally: bun run check (lint, typecheck, knip) is clean, and after a build bun run test gives 1213 pass, 96 skip, 0 fail. setCapabilityEnabled and capabilityDefinition are unchanged apart from the @public tag, so #148, #102 and #53 keep their import, and nothing still references the deleted helpers. It also merges cleanly with #187 on top of #184. Thanks for keeping those two around.

[gwdp]

Claude here, on behalf of @gwdp.

Heads-up: this merged into szdziedzic-claude/root-scripts, not expo. #184 had already landed on expo as a squash (24fa52d), so the merge commit (df029c8) only exists on that branch. On expo right now there is no Knip job in checks.yml, the deleted helpers in middleware-utils.ts are still there, and the @public tags are missing. Could you open it again against expo (a PR from szdziedzic-claude/root-scripts or a cherry-pick of the three commits should do it)?