Repository navigation
fix: eliminate variable shadowing in acceptParams function - #6981
Closed
SAURABHHAM44 wants to merge 1 commit into
Closed
SAURABHHAM44 wants to merge 1 commit into
SAURABHHAM44 wants to merge 1 commit into
Conversation
### What does this PR do? This PR fixes a variable shadowing issue in the acceptParams function in utils.js. The inner loop was redeclaring the 'colonIndex' variable, which shadowed the outer scope's variable with the same name. This has been fixed by renaming the inner variable to 'nextColonIndex'. ### Why is this change needed? Variable shadowing can lead to confusing code and potential bugs. By using distinct variable names for different purposes (colonIndex for the first semicolon search, nextColonIndex for subsequent searches within the loop), the code becomes clearer and easier to maintain. This follows best practices for code quality and readability. ### How was this tested? This is a code quality fix with no functional changes. The renaming maintains the exact same behavior - variable shadowing did not affect the logic, it was purely a code clarity issue.
jonchurch
requested changes
Jan 8, 2026
jonchurch
left a comment
jonchurch
left a comment
Member
There was a problem hiding this comment.
This change introduces a bug w/ an infinite loop. The code works fine as it is, and refactoring for the sake of it risks introducing the exact kind of bug this PR introduces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a variable shadowing issue in the acceptParams function in utils.js. The inner loop was redeclaring the 'colonIndex' variable, which shadowed the outer scope's variable with the same name. This has been fixed by renaming the inner variable to 'nextColonIndex'.
Why is this change needed?
Variable shadowing can lead to confusing code and potential bugs. By using distinct variable names for different purposes (colonIndex for the first semicolon search, nextColonIndex for subsequent searches within the loop), the code becomes clearer and easier to maintain. This follows best practices for code quality and readability.
How was this tested?
This is a code quality fix with no functional changes. The renaming maintains the exact same behavior - variable shadowing did not affect the logic, it was purely a code clarity issue.