Skip to content

fix(observer)!: merge observer ErrorType into flags::ErrorType - #795

Merged
ptondereau merged 1 commit into
masterfrom
fix/unify-error-type
Sep 29, 2026
Merged

ptondereau merged 1 commit into
masterfrom
fix/unify-error-type

Conversation

@ptondereau

Copy link
Copy Markdown
Member

Description

The observer had its own ErrorType next to flags::ErrorType, so php_error and the prelude disagreed, and its ALL did not match PHP's E_ALL before 8.4. The observer now uses flags::ErrorType, which gains All, Core and Fatal from the PHP headers and is exported from the prelude without a feature gate.

Checklist

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 36552728599

Coverage increased (+0.007%) to 70.575%

Details

  • Coverage increased (+0.007%) from the base build.
  • Patch coverage: 1 uncovered change across 1 file (17 of 18 lines covered, 94.44%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
src/zend/error_observer.rs 18 17 94.44%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 14270
Covered Lines: 10071
Line Coverage: 70.57%
Coverage Strength: 59.65 hits per line

💛 - Coveralls

@codspeed

codspeed Bot commented Sep 29, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 30 untouched benchmarks


Comparing fix/unify-error-type (9704f19) with master (932d762)

Open in CodSpeed

@ptondereau
ptondereau marked this pull request as ready for review September 29, 2026 10:36
@ptondereau
ptondereau merged commit a30982a into master Sep 29, 2026
72 checks passed
@ptondereau
ptondereau deleted the fix/unify-error-type branch September 29, 2026 10:36
@Xenira Xenira mentioned this pull request Sep 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants