Repository navigation
[#33] 마감된 경매 상태 변경 기능 - #34
Merged
Merged
Conversation
- Auction.close(): 입찰 유무(currentPrice > startPrice)로 SUCCESSFUL/FAILED 판정 - AuctionRepository.findAllByStatusAndExtendedClosesAtBefore 추가 - AuctionService.closeExpiredAuctions()에서 마감된 IN_PROGRESS 경매 일괄 마감 처리 - AuctionCloseScheduler: fixedDelay 기반 주기 실행 (scheduler.auction-close.fixed-delay, 기본 60초) - SchedulingConfig에 @EnableScheduling 분리
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Closed
|
pjy1368
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



개요
extendedClosesAt)이 지났는데도IN_PROGRESS상태로 남아있는 경매를 주기적으로 찾아 낙찰(SUCCESSFUL)/유찰(FAILED)로 전환하는 스케줄러 추가 (MVP1 수준)Auction.close(): 입찰 유무로 낙찰/유찰 여부를 판정하는 메서드 추가AuctionRepository.findAllByStatusAndExtendedClosesAtBefore: 마감 시각이 지난IN_PROGRESS경매 조회용 쿼리 추가AuctionCloseScheduler:@Scheduled(fixedDelayString = ...)로 주기 실행application.yaml의scheduler.auction-close.fixed-delay(기본 60초)로 외부에서 설정 가능SchedulingConfig:@EnableScheduling을 별도 설정 클래스로 분리메인 리뷰어 지정 및 Due Date
리뷰 시 참고 사항
TODO
References
[1] x
체크리스트