Skip to content

[#41] 아웃박스 발행 포기 시 입찰 실패 결과 저장 - #43

Merged
JIWON27 merged 2 commits into
mainfrom
fix/41
Nov 8, 2026
Merged

JIWON27 merged 2 commits into
mainfrom
fix/41

Conversation

@JIWON27

@JIWON27 JIWON27 commented Nov 8, 2026 •

Copy link
Copy Markdown
Collaborator

개요

  • 릴레이가 payload를 못 읽어 발행을 포기(FAILED)하면 bid_requests에 결과가 없어 사용자는 계속 "처리 중"으로 보이고 이후 최종 확정도 막힐 수 있는 문제가 있었습니다.
  • outbox에 bidder_id, bid_amount 컬럼을 추가하고, 발행 포기 시 outbox FAILED 변경과 BID_NOT_PROCESSED 실패 결과 저장을 한 트랜잭션(BidRequestService.rejectUnpublished)으로 처리합니다.

메인 리뷰어 지정 및 Due Date

  • 메인 리뷰어 : blue , Due Date : 2026-11-10

리뷰 시 참고 사항

  • 결과 저장이 실패하면 FAILED 변경도 롤백되어 PENDING으로 남고, 다음 릴레이 주기에 재시도합니다.

TODO

  • 입찰 접수 마감과 최종 낙찰 확정 분리

References

[1]

체크리스트

  • PR 제목을 명령형으로 작성했습니다.
  • PR을 연관되는 github issue에 연결했습니다.
  • 리뷰 리퀘스트 전에 셀프 리뷰를 진행했습니다
  • 변경사항에 대한 테스트코드를 추가했습니다. 또는, 테스트 코드가 필요없는 이유가 있습니다.

@JIWON27
JIWON27 requested a review from blue000927 November 8, 2026 01:14
@JIWON27 JIWON27 self-assigned this Nov 8, 2026
@coderabbitai

coderabbitai Bot commented Nov 8, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b4c23bbd-59d1-421a-b41c-fcdb53bcedda
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@sonarqubecloud

sonarqubecloud Bot commented Nov 8, 2026

Copy link
Copy Markdown

@JIWON27 JIWON27 linked an issue Nov 8, 2026 that may be closed by this pull request
@JIWON27
JIWON27 merged commit 5fe71d9 into main Nov 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task] 아웃박스 발행 포기 시 입찰 실패 결과 저장

2 participants