Skip to content

Fix StatsWrapper generated output path#614

Open
mavam wants to merge 1 commit intofacebook:mainfrom
mavam:fix-statswrapper-generation
Open

Fix StatsWrapper generated output path#614
mavam wants to merge 1 commit intofacebook:mainfrom
mavam:fix-statswrapper-generation

Conversation

@mavam
Copy link
Copy Markdown

@mavam mavam commented Apr 30, 2026

Summary:

  • Generate StatsWrapper.h under PROXYGEN_GENERATED_ROOT, matching the declared custom command output.
  • Create the stats output directory before running the generator.
  • Track gen_StatsWrapper.sh as an input and use VERBATIM for the command.

The generator writes to $1/proxygen/lib/stats/StatsWrapper.h, but the CMake rule passed PROXYGEN_FBCODE_ROOT while declaring the output below PROXYGEN_GENERATED_ROOT. This makes the generated output not match the declared custom command output.

Generate StatsWrapper.h under PROXYGEN_GENERATED_ROOT, matching the declared custom command output. Create the stats output directory before running the generator and track both generator inputs so incremental builds regenerate the header when needed.
@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented Apr 30, 2026

Hi @mavam!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented Apr 30, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed label Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant