Fix StatsWrapper generated output path#614
Conversation
Generate StatsWrapper.h under PROXYGEN_GENERATED_ROOT, matching the declared custom command output. Create the stats output directory before running the generator and track both generator inputs so incremental builds regenerate the header when needed.
|
Hi @mavam! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary:
The generator writes to $1/proxygen/lib/stats/StatsWrapper.h, but the CMake rule passed PROXYGEN_FBCODE_ROOT while declaring the output below PROXYGEN_GENERATED_ROOT. This makes the generated output not match the declared custom command output.