Skip to content

[RN] Move new event dispatching pipeline to RN#36266

Merged
rubennorte merged 1 commit intofacebook:mainfrom
rubennorte:move-event-dispatching-logic-to-rn
Apr 14, 2026
Merged

[RN] Move new event dispatching pipeline to RN#36266
rubennorte merged 1 commit intofacebook:mainfrom
rubennorte:move-event-dispatching-logic-to-rn

Conversation

@rubennorte
Copy link
Copy Markdown
Contributor

@rubennorte rubennorte commented Apr 14, 2026

Summary

We found a bug in the logic in #36253 and we realized it's very inconvenient to iterate on the implementation when it's in this repository, as we're forced to then synchronize it to RN to test changes.

This moves the entire implementation to RN for simplicity and also to simplify some clean ups in the future (like removing top prefixes from native event types).

How did you test this change?

The changes are gated. Will test e2e in RN.

@meta-cla meta-cla bot added the CLA Signed label Apr 14, 2026
@react-sizebot
Copy link
Copy Markdown

react-sizebot commented Apr 14, 2026

Comparing: 5682442...3902c46

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB = 1.88 kB 1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 612.91 kB 612.91 kB = 108.30 kB 108.30 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB = 1.88 kB 1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 678.85 kB 678.85 kB = 119.27 kB 119.27 kB
facebook-www/ReactDOM-prod.classic.js = 698.38 kB 698.38 kB = 122.68 kB 122.68 kB
facebook-www/ReactDOM-prod.modern.js = 688.69 kB 688.69 kB = 121.06 kB 121.06 kB
react-native/implementations/ReactFabric-dev.js = 797.03 kB 780.44 kB = 128.27 kB 125.19 kB
react-native/implementations/ReactFabric-profiling.fb.js = 511.87 kB 497.48 kB = 86.60 kB 83.94 kB
react-native/implementations/ReactFabric-profiling.js = 481.66 kB 467.25 kB = 81.42 kB 78.73 kB
react-native/implementations/ReactFabric-prod.fb.js = 438.39 kB 424.02 kB = 75.95 kB 73.27 kB
react-native/implementations/ReactFabric-prod.js = 414.73 kB 400.36 kB = 71.74 kB 69.08 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
react-native/implementations/ReactFabric-dev.fb.js = 834.38 kB 817.78 kB = 134.12 kB 131.03 kB
react-native/implementations/ReactFabric-dev.js = 797.03 kB 780.44 kB = 128.27 kB 125.19 kB
react-native/implementations/ReactFabric-profiling.fb.js = 511.87 kB 497.48 kB = 86.60 kB 83.94 kB
react-native/implementations/ReactFabric-profiling.js = 481.66 kB 467.25 kB = 81.42 kB 78.73 kB
react-native/implementations/ReactFabric-prod.fb.js = 438.39 kB 424.02 kB = 75.95 kB 73.27 kB
react-native/implementations/ReactFabric-prod.js = 414.73 kB 400.36 kB = 71.74 kB 69.08 kB

Generated by 🚫 dangerJS against 3902c46

@rubennorte rubennorte force-pushed the move-event-dispatching-logic-to-rn branch from da016ec to 3902c46 Compare April 14, 2026 16:29
@rubennorte rubennorte requested review from jackpope and javache April 14, 2026 16:51
@javache
Copy link
Copy Markdown
Member

javache commented Apr 14, 2026

This logic deals with Fiber though, which we've typically not exposed directly to RN before? I get that it's easier to iterate, but that seems like an important architectural shift to expose these internals to the RN codebase.

@rubennorte rubennorte merged commit 0418c8a into facebook:main Apr 14, 2026
236 checks passed
@rubennorte rubennorte deleted the move-event-dispatching-logic-to-rn branch April 14, 2026 17:10
@rubennorte
Copy link
Copy Markdown
Contributor Author

This logic deals with Fiber though, which we've typically not exposed directly to RN before? I get that it's easier to iterate, but that seems like an important architectural shift to expose these internals to the RN codebase.

The implementation in RN has changed to not use fibers and traverse via public instances instead, as we do for regular event dispatching.

github-actions bot pushed a commit that referenced this pull request Apr 14, 2026
## Summary

We found a bug in the logic in
#36253 and we realized it's very
inconvenient to iterate on the implementation when it's in this
repository, as we're forced to then synchronize it to RN to test
changes.

This moves the entire implementation to RN for simplicity and also to
simplify some clean ups in the future (like removing `top` prefixes from
native event types).

## How did you test this change?

The changes are gated. Will test e2e in RN.

DiffTrain build for [0418c8a](0418c8a)
github-actions bot pushed a commit to code/lib-react that referenced this pull request Apr 19, 2026
## Summary

We found a bug in the logic in
facebook#36253 and we realized it's very
inconvenient to iterate on the implementation when it's in this
repository, as we're forced to then synchronize it to RN to test
changes.

This moves the entire implementation to RN for simplicity and also to
simplify some clean ups in the future (like removing `top` prefixes from
native event types).

## How did you test this change?

The changes are gated. Will test e2e in RN.

DiffTrain build for [0418c8a](facebook@0418c8a)
github-actions bot pushed a commit to code/lib-react that referenced this pull request Apr 19, 2026
## Summary

We found a bug in the logic in
facebook#36253 and we realized it's very
inconvenient to iterate on the implementation when it's in this
repository, as we're forced to then synchronize it to RN to test
changes.

This moves the entire implementation to RN for simplicity and also to
simplify some clean ups in the future (like removing `top` prefixes from
native event types).

## How did you test this change?

The changes are gated. Will test e2e in RN.

DiffTrain build for [0418c8a](facebook@0418c8a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants