feat(react-tapi)!: remove useLacy hook#362
Conversation
Remove the useLacy hook and its tests from @farbenmeer/react-tapi. The @farbenmeer/lacy dependency is no longer needed. Update the bunny boilerplate, env-file example, and docs to use useQuery instead. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JeCkG2W6Mji6kyRfoavJL2
🦋 Changeset detectedLatest commit: d4491da The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JeCkG2W6Mji6kyRfoavJL2
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JeCkG2W6Mji6kyRfoavJL2
|
🤖 Opened a ColorCode session for this thread. |
There was a problem hiding this comment.
Overall Review
This is a clean removal of the useLacy hook. The implementation looks correct: the source files and tests are deleted, the index export is updated, the @farbenmeer/lacy dependency is dropped, and all consumers have been migrated to useQuery. The docs update is accurate, and no residual useLacy/use-lacy references remain in source or test files.
I found one issue that needs to be addressed before approval:
1. Changeset: @farbenmeer/bunny should be major, not minor
@farbenmeer/bunny re-exports everything from @farbenmeer/react-tapi via export * from "@farbenmeer/react-tapi" in its /client entry (packages/3-bunny/src/client.tsx). Since useLacy was previously part of that public surface, removing it is a breaking change for bunny consumers too. The changeset currently marks @farbenmeer/bunny as minor — it should be major.
Acceptance Criteria
- Changeset: change
"@farbenmeer/bunny"fromminortomajor -
use-lacy.tsanduse-lacy.test.tsxare deleted -
useLacyexport removed frompackages/2-react-tapi/src/index.ts -
@farbenmeer/lacydependency removed frompackages/2-react-tapi/package.jsonand lockfile -
packages/4-bunny-boilerplate/src/app/app.tsxusesuseQueryinstead ofuseLacy -
examples/env-file/src/app/app.tsxusesuseQueryinstead ofuseLacy -
website/src/content/docs/bunny/reference/start-bunny-client.mdupdated to referenceuseQuery - No remaining
useLacyoruse-lacyreferences in source/test files (.ts,.tsx,.mdx,.mddocs) - All consuming examples (contact-book, tables, todo-list) should ideally be tested or at minimum visually checked that they still render correctly after the migration
| @@ -0,0 +1,7 @@ | |||
| --- | |||
| "@farbenmeer/react-tapi": major | |||
| "@farbenmeer/bunny": minor | |||
There was a problem hiding this comment.
Issue: @farbenmeer/bunny re-exports everything from @farbenmeer/react-tapi via export * in packages/3-bunny/src/client.tsx. Since useLacy was previously part of that public re-export surface, removing it is a breaking change for bunny consumers too. This should be "@farbenmeer/bunny": major, not minor.
Summary
Removes the
useLacyhook from@farbenmeer/react-tapias requested.Changes
use-lacy.tsanduse-lacy.test.tsxuseLacyexport from the package index@farbenmeer/lacydependency fromreact-tapi'spackage.json(and lockfile)useQueryinstead:packages/4-bunny-boilerplate/src/app/app.tsxexamples/env-file/src/app/app.tsx(was only importinguseLacyunused)website/src/content/docs/bunny/reference/start-bunny-client.md@farbenmeer/react-tapiand@farbenmeer/bunnyas major (breaking: public export removed;@farbenmeer/bunnyre-exports everything fromreact-tapi)Verification
pnpm test runinpackages/2-react-tapipasses (5 tests) after building@farbenmeer/tapiuseLacy/use-lacyreferences in the repo🤖 Generated with Claude Code
Generated by Claude Code