Skip to content

feat(react-tapi)!: remove useLacy hook#362

Merged
mismosmi merged 3 commits into
mainfrom
claude/charming-faraday-96vhen
Jun 23, 2026
Merged

feat(react-tapi)!: remove useLacy hook#362
mismosmi merged 3 commits into
mainfrom
claude/charming-faraday-96vhen

Conversation

@mismosmi

Copy link
Copy Markdown
Member

Summary

Removes the useLacy hook from @farbenmeer/react-tapi as requested.

Changes

  • Delete use-lacy.ts and use-lacy.test.tsx
  • Drop the useLacy export from the package index
  • Remove the now-unused @farbenmeer/lacy dependency from react-tapi's package.json (and lockfile)
  • Update consumers to use useQuery instead:
    • packages/4-bunny-boilerplate/src/app/app.tsx
    • examples/env-file/src/app/app.tsx (was only importing useLacy unused)
    • website/src/content/docs/bunny/reference/start-bunny-client.md
  • Add a changeset marking @farbenmeer/react-tapi and @farbenmeer/bunny as major (breaking: public export removed; @farbenmeer/bunny re-exports everything from react-tapi)

Verification

  • pnpm test run in packages/2-react-tapi passes (5 tests) after building @farbenmeer/tapi
  • No remaining useLacy / use-lacy references in the repo

🤖 Generated with Claude Code


Generated by Claude Code

Remove the useLacy hook and its tests from @farbenmeer/react-tapi. The
@farbenmeer/lacy dependency is no longer needed. Update the bunny
boilerplate, env-file example, and docs to use useQuery instead.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JeCkG2W6Mji6kyRfoavJL2
@changeset-bot

changeset-bot Bot commented Jun 18, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d4491da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@farbenmeer/react-tapi Major
@farbenmeer/bunny Minor
@farbenmeer/tapi-example-tables Patch
@farbenmeer/bunny-boilerplate Patch
@farbenmeer/bunny-example-contact-book Patch
@farbenmeer/bunny-example-env-file Patch
@farbenmeer/bunny-example-todo-list Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment thread .changeset/remove-use-lacy.md Outdated
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JeCkG2W6Mji6kyRfoavJL2
Comment thread website/src/content/docs/bunny/reference/start-bunny-client.md Outdated
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JeCkG2W6Mji6kyRfoavJL2
@mismosmi mismosmi marked this pull request as ready for review June 23, 2026 08:50
@farbenmeer-code

Copy link
Copy Markdown

🤖 Opened a ColorCode session for this thread.

@farbenmeer-code farbenmeer-code Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall Review

This is a clean removal of the useLacy hook. The implementation looks correct: the source files and tests are deleted, the index export is updated, the @farbenmeer/lacy dependency is dropped, and all consumers have been migrated to useQuery. The docs update is accurate, and no residual useLacy/use-lacy references remain in source or test files.

I found one issue that needs to be addressed before approval:

1. Changeset: @farbenmeer/bunny should be major, not minor

@farbenmeer/bunny re-exports everything from @farbenmeer/react-tapi via export * from "@farbenmeer/react-tapi" in its /client entry (packages/3-bunny/src/client.tsx). Since useLacy was previously part of that public surface, removing it is a breaking change for bunny consumers too. The changeset currently marks @farbenmeer/bunny as minor — it should be major.

Acceptance Criteria

  • Changeset: change "@farbenmeer/bunny" from minor to major
  • use-lacy.ts and use-lacy.test.tsx are deleted
  • useLacy export removed from packages/2-react-tapi/src/index.ts
  • @farbenmeer/lacy dependency removed from packages/2-react-tapi/package.json and lockfile
  • packages/4-bunny-boilerplate/src/app/app.tsx uses useQuery instead of useLacy
  • examples/env-file/src/app/app.tsx uses useQuery instead of useLacy
  • website/src/content/docs/bunny/reference/start-bunny-client.md updated to reference useQuery
  • No remaining useLacy or use-lacy references in source/test files (.ts, .tsx, .mdx, .md docs)
  • All consuming examples (contact-book, tables, todo-list) should ideally be tested or at minimum visually checked that they still render correctly after the migration

@@ -0,0 +1,7 @@
---
"@farbenmeer/react-tapi": major
"@farbenmeer/bunny": minor

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: @farbenmeer/bunny re-exports everything from @farbenmeer/react-tapi via export * in packages/3-bunny/src/client.tsx. Since useLacy was previously part of that public re-export surface, removing it is a breaking change for bunny consumers too. This should be "@farbenmeer/bunny": major, not minor.

@mismosmi mismosmi merged commit 7f8b5f0 into main Jun 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants