Repository navigation
fix(service-version): describe stage --version as a draft version - #1958
Closed
Tyagiquamar wants to merge 2 commits into
Closed
Tyagiquamar wants to merge 2 commits into
Tyagiquamar wants to merge 2 commits into
Conversation
service version stage rejects active and locked versions, but --help reused the generic description that advertises latest, active, and staged. Fixes fastly#1320.
|
Thanks for the contribution! This pull request doesn't follow our pull request template:
Please edit the description to use the template. If it is still missing after 3 days, this pull request will be closed automatically. |
|
Closing because the pull request template is still missing after 3 days. Feel free to open a new pull request that uses the template. |
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fastly service-version stage --helpdescribes--versionas a draft version.Root cause
stagerejects active and locked versions, but--helpreused the generic version description that lists latest, active, and staged.Solution
The stage command uses its own description: the flag selects a draft version.
Test plan
pkg/commands/service/version/serviceversion_test.gocovers the help text.Fixes #1320