Repository navigation
Fix list settings not having variables resolved - #48462
Merged
Merged
Conversation
jkarneges
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #48321,
Settings::value()is checking for aVariantType::List, but the settings return aQStringListin string list instances, so list values never had their variables substituted. For example,settings.value("proxy/m2a_in_specs")returned both its items with{rundir}and{ipc_prefix}unsubstituted.This change adds the
VariantType::StringListenum forQStringListitems and converts the check.Tested locally