Skip to content

Added ref prop to IconProps interface#79

Open
filingroove wants to merge 2 commits into
feathericons:masterfrom
filingroove:master
Open

Added ref prop to IconProps interface#79
filingroove wants to merge 2 commits into
feathericons:masterfrom
filingroove:master

Conversation

@filingroove

Copy link
Copy Markdown

Fix for #78

@filingroove filingroove changed the title Switched type FC to ForwardRefRenderFunction in Icon Added ref prop to IconProps interface Dec 21, 2020
@elliott-king

elliott-king commented Aug 29, 2022

Copy link
Copy Markdown

@carmelopullara apologies for the spam, just wanted to draw your attention. react-feather does not currently support refs with TS.

@amhunt

amhunt commented Sep 29, 2023

Copy link
Copy Markdown

@carmelopullara not urgent, but any chance we could merge this one? We're also experiencing a TS error here

@tounsoo

tounsoo commented Apr 6, 2024

Copy link
Copy Markdown

Following this

@tounsoo

tounsoo commented Apr 28, 2024

Copy link
Copy Markdown

With React19, it looks like ref is now included.
React19 beta announcement / ref as prop

I also found type issue while testing out react19 and have reported the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants