Skip to content

Use kyoto's rescan_from(h) instead of rescan() #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
randomlogin wants to merge 1 commit into from
Closed

Use kyoto's rescan_from(h) instead of rescan() #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/chain/cbf.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,7 +548,14 @@ impl CbfChainSource {
let (tx, rx) = oneshot::channel();
*self.sync_completion_tx.lock().expect("lock") = Some(tx);

if let Err(e) = requester.rescan().map_err(|e| {
// Delegate the skip to kyoto so it doesn't re-stream filters we would discard
// client-side via filter_skip_height. Without `_from`, kyoto replays from its
// build-time checkpoint (potentially genesis on a fresh wallet) every tick.
let rescan_res = match skip_before_height {
Some(h) => requester.rescan_from(h),
None => requester.rescan(),
};
if let Err(e) = rescan_res.map_err(|e| {
log_error!(self.logger, "Failed to trigger CBF rescan: {:?}", e);
Error::WalletOperationFailed
}) {
Expand Down
Loading