Sync integration with the new Develop Changes - #2346
Merged
Merged
Conversation
Co-authored-by: Kier Petrov <kpetrov@apple.com>
…ing QueryActor (#2332) * Adding cardinality collection in coordinator actor to avoid load in QueryActor
…2345) * Open java.util.regex for JDK 21 so Kryo can serialize regex filters Filter.EqualsRegex and Filter.NotEqualsRegex keep a compiled java.util.regex.Pattern as a field: final case class EqualsRegex(value: Any) extends Filter { val pattern = Pattern.compile(value.toString, Pattern.DOTALL) That Pattern rides along inside ExecPlans sent over akka remoting, nested as LocalPartitionReduceAggregateExec.childAggregates -> MultiSchemaPartitionsExec.filters -> ColumnFilter.filter -> Filter$EqualsRegex.pattern. akka-kryo-serialization has no serializer registered for Pattern, so Kryo falls back to the reflective FieldSerializer. On JDK 16+ that serializer cannot even be constructed, because java.base does not open java.util.regex: IllegalArgumentException: Unable to create serializer "FieldSerializer" for class: java.util.regex.Pattern Measured on JDK 21.0.12, 26 of Pattern's 35 declared fields throw InaccessibleObjectException ("module java.base does not opens java.util.regex to unnamed module"); Pattern also has no no-arg constructor. After adding this open, all 35 are accessible. These opens are NOT recursive, so the existing --add-opens=java.base/java.util entry does not cover the java.util.regex subpackage. The failure surfaces while DESERIALIZING on the receiving node, so akka declares the association failed and gates the peer for 5s. While gated, every query to that node fails, not only the regex one -- observed as HTTP 500 "Shard: N is not available" across all queries on a cluster whose shards were all active and healthy. Verified on a live 2-node cluster by adding the flag and restarting: Pattern setAccessible went from ok=9/fail=26 to ok=35/fail=0, the Kryo Pattern errors went from ~1000 per node to 0, and PromQL regex matchers went from failing every request to succeeding. jdk21ModuleOpens is consumed both by the test settings here and, in the Apple packaging module, by javaOptions in Universal, which emits conf/application.ini for the packaged launcher -- so this one entry covers tests and shipped artifacts alike. * Remove comments about regex open options Removed comments explaining the need for regex opens. --------- Co-authored-by: Siri Varma Vegiraju <s_vegiraju@apple.com>
* feat(query): Adding LabelAudit logicalPlan holder to the queries
alextheimer
approved these changes
Sep 28, 2026
Contributor
|
please update the PR description or remove the placeholder message |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request checklist