Repository navigation
docs: plan the Morphir extension model and step 0 registry, add F#/C# interop tooling - #501
Merged
Merged
Conversation
- Built-in, WASM and process extensions on the upstream MEP contract - Analyzer (MEP validator) as the first capability, IR V4 JSON first - Staged folders and discovery levels as a superset of the upstream store - Ordered steps with spikes for JSON-RPC, the WASM runtime and Roslyn AOT
Define the zipped package as one zip of the loose upstream release assets, with safe extraction, digest checks and target selection.
The staged folders and extension install accept the extension package archive as zip or tar gzip, with the same layout and the same safety checks.
Replace string, enum and flag members with parsed values and closed unions, type the generation contracts the registry reads, and allow dotted extension ids as a superset of upstream.
Add the fsharp-csharp-interop skill in .agents/skills with copies for Claude Code and Grok Build, the fsharp-csharp-interop-reviewer agent for Claude Code, Codex, GitHub Copilot and Grok Build, file-pattern rules for Copilot and Cursor, and scripts/sync-agent-skills.fsx to write and check the copies.
Add decisions LANG-1 (F# domain project, C# CLI edge) and FFI-1 (interop rules), rewrite TYP-1 and REG-1 in F#, and add the F# project setup tasks.
Run scripts/sync-agent-skills.fsx --check as a step of the lint job, after a successful SDK setup and even when the format check fails, with a GitHub annotation on each drifted file. Add a Husky.Net pre-commit task that runs only when staged files are under a skills folder.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Plans an incremental extension model for morphir-dotnet and adds the contributor tooling for its first step. Refs #492.
Morphir extension model PRD (
docs/content/contributing/design/prds/morphir-extension-model.md, Approved)validator) is the first capability, with IR V4 JSON input.staged/folders that accept a bare.wasmand an extension package archive (zip or tar gzip of the loose upstream release assets). It is shipped as a documented superset of the upstream store, catalog and lock format.OpenSpec change
add-extension-registry(step 0, planning only)Morphir.Extensions) with a C# CLI edge. Parsed domain types and closed unions: no strings or enums validated later.morphir extension listreports the built-in generators (morphir.csharp,morphir.fsharp) in both hosts. Extension ids are dotted portable tokens, a superset of the upstream rule; the closeout proposes this upstream.extension listmoves from not-implemented to a result; the otherextensionsubcommands stay on Wire the morphir extension sub-commands to their handlers #492.fsharp-csharp-interopskill and reviewer agent.agents/skills/(Codex, GitHub Copilot, Cursor, Muse Code), with copies in.claude/skills/and.grok/skills/written byscripts/sync-agent-skills.fsx.fsharp-csharp-interop-revieweragent for Claude Code and Cursor (.claude/agents), Codex (.codex/agents), GitHub Copilot (.github/agents) and Grok Build (.grok/agents). File-pattern rules for Copilot (.github/instructions) and Cursor (.cursor/rules).Create(null)with no warning; with it, the call fails with CS8625.CI and pre-commit
lintjob:dotnet fsi scripts/sync-agent-skills.fsx --checkafter a successful SDK setup, also when the format check fails (about a second, no restore). Each drifted file gets a GitHub annotation.agent-skill-copies: runs only when staged files are under a skills folder.Types of changes
Checklist
openspec validate --all --strict(26 passed),sync-agent-skills.fsx --check(clean, and exit 1 with annotations on drift), Husky task (skipped for unrelated staged files, fails in about 0.6 s on staged drift), Fantomas check on the new script, actionlint (no new findings)..cursorrules, Copilot instructions,.agents/skills-reference.mdand.agents/capabilities-matrix.md.Further comments
main:development.ymlline 16 marks theconfigurationinput as both required and defaulted. It is not changed here.