Skip to content

docs: plan the Morphir extension model and step 0 registry, add F#/C# interop tooling - #501

Merged
DamianReeves merged 11 commits into
mainfrom
t3/incremental-wasm-plugin-model
Nov 7, 2026
Merged

DamianReeves merged 11 commits into
mainfrom
t3/incremental-wasm-plugin-model

Conversation

@DamianReeves

Copy link
Copy Markdown
Member

Proposed Changes

Plans an incremental extension model for morphir-dotnet and adds the contributor tooling for its first step. Refs #492.

Morphir extension model PRD (docs/content/contributing/design/prds/morphir-extension-model.md, Approved)

  • Built-in, WASM and process extensions under the Morphir Extension Protocol (MEP). WASM is the cornerstone; the analyzer (MEP validator) is the first capability, with IR V4 JSON input.
  • Delivery steps 0 to 5 that each merge on their own, plus spikes (JSON-RPC library, WASM runtime, .NET guest toolchains, Roslyn under AOT).
  • Discovery levels with staged/ folders that accept a bare .wasm and an extension package archive (zip or tar gzip of the loose upstream release assets). It is shipped as a documented superset of the upstream store, catalog and lock format.

OpenSpec change add-extension-registry (step 0, planning only)

fsharp-csharp-interop skill and reviewer agent

  • Canonical skill in .agents/skills/ (Codex, GitHub Copilot, Cursor, Muse Code), with copies in .claude/skills/ and .grok/skills/ written by scripts/sync-agent-skills.fsx.
  • fsharp-csharp-interop-reviewer agent for Claude Code and Cursor (.claude/agents), Codex (.codex/agents), GitHub Copilot (.github/agents) and Grok Build (.grok/agents). File-pattern rules for Copilot (.github/instructions) and Cursor (.cursor/rules).
  • The skill's patterns were compiled against .NET 10. Without F# nullness metadata, C# accepts Create(null) with no warning; with it, the call fails with CS8625.

CI and pre-commit

  • lint job: dotnet fsi scripts/sync-agent-skills.fsx --check after a successful SDK setup, also when the format check fails (about a second, no restore). Each drifted file gets a GitHub annotation.
  • Husky.Net task agent-skill-copies: runs only when staged files are under a skills folder.

Types of changes

  • New feature (non-breaking change which adds functionality): documentation, planning artifacts and contributor tooling. No product code changes.

Checklist

  • Build and tests pass locally: no product code changed. openspec validate --all --strict (26 passed), sync-agent-skills.fsx --check (clean, and exit 1 with annotations on drift), Husky task (skipped for unrelated staged files, fails in about 0.6 s on staged drift), Fantomas check on the new script, actionlint (no new findings).
  • I have added tests that prove my fix is effective or that my feature works: not applicable; the check script was exercised manually as listed above.
  • I have added necessary documentation: AGENTS.md, CLAUDE.md, .cursorrules, Copilot instructions, .agents/skills-reference.md and .agents/capabilities-matrix.md.

Further comments

  • actionlint reports one finding that is already on main: development.yml line 16 marks the configuration input as both required and defaulted. It is not changed here.
  • Discovery of the skill and agent was confirmed in Claude Code. The other tools follow their documentation; Grok agent fields and Codex agent names are not fully documented.

- Built-in, WASM and process extensions on the upstream MEP contract
- Analyzer (MEP validator) as the first capability, IR V4 JSON first
- Staged folders and discovery levels as a superset of the upstream store
- Ordered steps with spikes for JSON-RPC, the WASM runtime and Roslyn AOT
Define the zipped package as one zip of the loose upstream release assets, with safe extraction, digest checks and target selection.
The staged folders and extension install accept the extension package archive as zip or tar gzip, with the same layout and the same safety checks.
Replace string, enum and flag members with parsed values and closed unions, type the generation contracts the registry reads, and allow dotted extension ids as a superset of upstream.
Add the fsharp-csharp-interop skill in .agents/skills with copies for Claude Code and Grok Build, the fsharp-csharp-interop-reviewer agent for Claude Code, Codex, GitHub Copilot and Grok Build, file-pattern rules for Copilot and Cursor, and scripts/sync-agent-skills.fsx to write and check the copies.
Add decisions LANG-1 (F# domain project, C# CLI edge) and FFI-1 (interop rules), rewrite TYP-1 and REG-1 in F#, and add the F# project setup tasks.
Run scripts/sync-agent-skills.fsx --check as a step of the lint job, after a successful SDK setup and even when the format check fails, with a GitHub annotation on each drifted file. Add a Husky.Net pre-commit task that runs only when staged files are under a skills folder.
…nt commands

Since #489, extension list fails with a link to #492. Link step 0 to #492, and plan the removal of the extension list row from CliManagementCommands.feature.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-07T16:12:12.377469Z 2cd0c58 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@DamianReeves
DamianReeves merged commit a5f91af into main Nov 7, 2026
8 checks passed
@DamianReeves
DamianReeves deleted the t3/incremental-wasm-plugin-model branch November 7, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant