Repository navigation
build(deps): pin moonrockz/extism 0.1.1 for fast WASM workers on Windows - #304
Merged
Merged
Conversation
moonrockz/extism 0.1.1 makes the WAMR suspend flags atomic on Windows MSVC. In 0.1.0 every branch, loop and call locked a Win32 mutex, so the native Elm 0.5.0-preview.2 compile passed the 10000 ms per-call deadline on windows-latest (run 41258285145, 11356 ms). No host code changes. Refs: morphir-ukvn.5.64.36.20, morphir-ukvn.5.64.36.7
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Run 41270893387 on windows-latest with moonrockz/extism 0.1.1 passes the elm, python, moonbit-native and conformance suites. The native Elm 0.5.0-preview.2 compile takes 1628 ms of the 10000 ms per-call deadline. The other failures are the recorded known failures (beads .16, .17, .18). Refs: morphir-ukvn.5.64.36.7, morphir-ukvn.5.64.36.20 Tested-on: windows-latest (run 41270893387)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This changes the pin of
moonrockz/extisminpkgs/morphir-host/moon.modfrom0.1.0to0.1.1. The README ofworker/wasmnames the new version. No host code changes, and no public interface changes.moonrockz/extism0.1.1 makes the WAMR suspend flags atomic on Windows MSVC. In 0.1.0, every branch, loop and call locked a Win32 mutex. On windows-latest, moonrockz/extism measured:In this repository, run 41258285145 showed the native Elm 0.5.0-preview.2 compile at 11356 ms. The per-call deadline is 10000 ms (bead
morphir-ukvn.5.64.36.20).Tests (macOS arm64)
mise run test:wasm-workers -- --target native --scope workers: 25 of 25 passmise run test:wasm-workers -- --target js --scope workers: 16 of 16 passmoon test --deny-warnonworker/wasm(native 16, js 16),worker/wasm/guest(native 40, js 35) andworker/wasm/native(25): all passWindows qualification
Run 41270893387 (windows-latest, x86_64-pc-windows-msvc, suite
all, head 04af639) downloadsmoonrockz/extism@0.1.1. The elm, python, moonbit-native and conformance suites pass. The job takes 12 minutes..16)The failures are the recorded known failures: the Elm 0.4.1 compile (bead
morphir-ukvn.5.64.36.16),shared-kit-directwith the retired kit profile (bead.17), and the moonbit-portable suite, because the portable guest is not packaged on Windows (bead.18,bridge.jscopy ENOENT). Thus the run ends with status 1. Artifact 13070050322,sha256:7a67866d242bcf7c39f203494b80533046cb1d00b8b25c4f92097415852b8ccd.Thus the second commit ticks task 7.5 of
host-extensions-as-workerswith the trailerTested-on: windows-latest (run 41270893387).Open follow-ups
morphir-ukvn.5.64.36.18: the portable MoonBit guest is not packaged on Windows.morphir-ukvn.5.64.36.21: the CLI reports a call-deadline fault as "the session deadline passed".