fix(shadcn): migrate form components from Form to Field API#1369
Merged
Conversation
- Migrated all 9 form components from the removed `@/components/ui/form` to shadcn's current `@/components/ui/field` component. - Added `react-hook-form` and `@hookform/resolvers` to registry dependencies so they are installed when users add components. - Deleted unused `form.tsx` wrapper component. Fixes #1367
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates several authentication forms in the shadcn package from the old Form API to a new Field API, replacing FormField with Controller and updating the registry specifications and tests accordingly. The review feedback highlights that this migration breaks automatic accessibility linking and error state styling. To resolve this, the reviewer recommends explicitly passing htmlFor to FieldLabel, id and aria-invalid to the input components, and data-invalid to the Field wrappers across all migrated forms.
dackers86
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1367
@/components/ui/formto shadcn's current@/components/ui/fieldcomponent.react-hook-formand@hookform/resolversto registry dependencies so they are installed when users add components.form.tsxwrapper component.demo.video.mp4