QEMU Networking using slirp and vdeplug4#235
Draft
raghav-g13 wants to merge 17 commits into
Draft
Conversation
raghav-g13
changed the title
raghav-g13
changed the title
NathanTP
reviewed
Apr 1, 2022
NathanTP
left a comment
NathanTP
left a comment
Contributor
There was a problem hiding this comment.
Some high level stuff:
- The IP addresses aren't quite right. They need to precisely match what FireSim would give.
- Jobs should start at 172.16.0.2, the gateway should be at 172.16.0.1. We need to figure out how to configure the DNS. I think we can use a public DNS server instead of hosting our own (8.8.8.8 is Google's).
- All this needs to be tested with FireSim eventually.
- We shouldn't commit binaries for client and server in the buildroot and fedora NW tests. Those should get built from source in a host-init script.
- You should merge in main to get the multi-job stuff in there. I think some of that is being duplicated here which is making it hard to review.
| FireMarshal does not currently support running networked jobs concurrently. | ||
| However, you can run multiple jobs in a single launch command, they will be run | ||
| sequentially. Jobs are identified by their ``name`` attribute. Multiple ``-j`` | ||
| FireMarshal supports running multiple jobs concurrently but does not support networked jobs yet. Jobs are identified by their ``name`` attribute. Multiple ``-j`` |
Merging final parallelJobs files in to avoid duplicate commits + other master changes
NathanTP
reviewed
Apr 8, 2022
NathanTP
left a comment
NathanTP
left a comment
Contributor
There was a problem hiding this comment.
This seems pretty good now. I think the only problems are formatting. The C files have some funny tab sizes going on and the automatic lint checks seem to be failing.
|
|
||
| int t = 0; | ||
| while(1){ | ||
|
|
…ded dependencies dir to .gitignore
raghav-g13
force-pushed
the
qemu-network
branch
from
02cc639 to
606416a
Compare
creates a subshell and messes everything up). This also refactors some stuff to make it simpler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.