Skip to content

[TLE][TEST] Skip raw MLIR cache-key test without bindings - #938

Merged
zhzhcookie merged 2 commits into
flagos-ai:mainfrom
zihaomu:fix/tle-raw-cache-key-optional-mlir
Aug 15, 2026
Merged

[TLE][TEST] Skip raw MLIR cache-key test without bindings#938
zhzhcookie merged 2 commits into
flagos-ai:mainfrom
zihaomu:fix/tle-raw-cache-key-optional-mlir

Conversation

@zihaomu

@zihaomu zihaomu commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

What

Skip only the MLIR-specific raw cache-key test when the optional mlir Python bindings are unavailable. The remaining raw cache-key tests continue to run normally.

Why

test_mlir_dialect_cache_key_changes_with_edsl_source constructs an @dialect(name="mlir") function. This loads the optional MLIR Python bindings and raises ModuleNotFoundError: No module named 'mlir' in environments where those bindings are not installed.

Testing

  • python -m pytest python/test/tle/unit/test_tle_raw_cache_key.py -q
    • 5 passed, 1 skipped without MLIR bindings
  • MLIR-specific test with available bindings: 1 passed, 5 deselected
  • Incomplete MLIR installation still reports ImportError
  • Ruff 0.9.1, YAPF 0.43.0, Python syntax, and git diff --check passed

The MLIR cache-key test requires the optional mlir Python bindings. Skip only that test when the dependency is unavailable so the remaining raw cache-key tests continue to run.

@zhzhcookie zhzhcookie left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhzhcookie zhzhcookie left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhzhcookie
zhzhcookie merged commit 701eb61 into flagos-ai:main Aug 15, 2026
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants