Skip to content

feat: support gd32vw55x#99

Closed
kaidegit wants to merge 2 commits into
florisla:masterfrom
kaidegit:master
Closed

feat: support gd32vw55x#99
kaidegit wants to merge 2 commits into
florisla:masterfrom
kaidegit:master

Conversation

@kaidegit

@kaidegit kaidegit commented Mar 16, 2026

Copy link
Copy Markdown

No description provided.

@kaidegit kaidegit marked this pull request as draft March 17, 2026 13:20
@florisla florisla added the devices Related to a specific target devce label Mar 17, 2026
@florisla

florisla commented Mar 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner

Hi, do you expect any more changes? The PR is still 'Draft'.

Of course it would be nice to have the GigaDevices behaviour covered by some unit tests.

The current linting and test issues can be waved; I can fix those after merging.

@florisla florisla added the approved Will be included in the next release label Mar 17, 2026
@florisla florisla added this to the v1.0.0 milestone Mar 17, 2026
@kaidegit

kaidegit commented Mar 17, 2026

Copy link
Copy Markdown
Author

I think DeviceFlag.FIXED_FLASH_SIZE is no need, we could do like https://github.com/florisla/stm32loader/pull/98/changes#diff-a12728ab1b5ece68f7cf58cec18dfac027c9da3999af65564bfff0877fdfbed6R507

I would fix it tomorrow, because i should go to bed today.

If you don't mind this, I can change it to ready and you can merge.

@kaidegit

kaidegit commented Mar 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

I think this https://github.com/florisla/stm32loader/pull/99/changes#diff-a12728ab1b5ece68f7cf58cec18dfac027c9da3999af65564bfff0877fdfbed6R650 could be a standalone bug fix, should not included here?

@kaidegit

kaidegit commented Mar 17, 2026

Copy link
Copy Markdown
Author

This may not work well when -w without -e. It wouldn't trigger page erase. I may try to find why tomorrow.

@florisla

florisla commented Mar 17, 2026

Copy link
Copy Markdown
Owner

Hi, I agree with taking the approach from #98. No pressure to get this done quickly; take your time!

@kaidegit

kaidegit commented Mar 19, 2026

Copy link
Copy Markdown
Author

move to #102 and #101

@kaidegit kaidegit closed this Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

approved Will be included in the next release devices Related to a specific target devce

Projects

None yet

Milestone

v1.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@kaidegit @florisla