Skip to content

fix(folders): don't send "None" as the folder description #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deveaud-m merged 3 commits into from
Oct 30, 2026
Merged

fix(folders): don't send "None" as the folder description #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37430a3
fix(folders): don't send "None" as the folder description
syahra712 Oct 18, 2026
976d2b5
test(folders): check folder without description on a real instance
syahra712 Oct 19, 2026
92d71de
test(uploads): use upload ids that cannot exist in permission tests
syahra712 Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion fossology/folders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,9 @@ def create_folder(
headers = {
"parentFolder": f"{parent.id}",
"folderName": f"{name}",
"folderDescription": f"{description}",
}
if description:
headers["folderDescription"] = description
if group:
headers["groupName"] = group

Expand Down
11 changes: 11 additions & 0 deletions tests/test_folders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,17 @@ def test_list_folders_error(foss_server: str, foss: Fossology):
assert f"Unable to get a list of folders for {foss.user.name}" in str(excinfo.value)


def test_create_folder_without_description(foss: Fossology):
name = "FossPythonTestNoDesc"
test_folder = foss.create_folder(foss.rootFolder, name)
assert test_folder.name == name
# an unset description must not be stored as the literal string "None"
assert test_folder.description == ""

# Cleanup
foss.delete_folder(test_folder)


def test_create_folder_nogroup(foss: Fossology):
name = "FossPythonTest"
desc = "Created via the Fossology Python API"
Expand Down
4 changes: 2 additions & 2 deletions tests/test_upload_permissions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def test_get_upload_permissions_if_upload_does_not_exists_raise_api_error(
upload = Upload(
1,
"non-existing-folder",
secrets.randbelow(1092),
1_000_000 + secrets.randbelow(1000),
"non-existing upload",
"none",
"2023-08-07",
Expand Down Expand Up @@ -91,7 +91,7 @@ def test_change_upload_permissions_if_upload_does_not_exists_raise_api_error(
upload = Upload(
1,
"non-existing-folder",
secrets.randbelow(192),
1_000_000 + secrets.randbelow(1000),
"non-existing upload",
"none",
"2023-08-07",
Expand Down
Loading