Frappe Update 5cba016e86 -> 988e54f3c4 failed w/ Python syntax errors: multiple exception types must be parenthesized

[peerDE]

After seeing this:

Updates
1 of 1 selected
  frappe
  5cba016e86 -> 988e54f3c4
Take backup of sites

the update failed:

[Server] (http://localhost:7002/insights/tasks/20260911-115002-b2cd6f)

11.09.2026, 11:508s
Updating apps
Updating frappe...
Validating frappe...
Error: 'frappe' has Python syntax errors:
  frappe/database/query.py: line 87: multiple exception types must be parenthesized
  frappe/model/delete_doc.py: line 152: multiple exception types must be parenthesized
Error: 1

This was from pilot 29 to 32. The same thing happened on another pilot update from 29 to 31.

[peerDE]

Still doesn't work with Pilot v33.

(Guess it'll need the next Framework version, e.g. after 16.33.1.)

[ai-sadhu]

facing same issue ..

[tanmoysrt]

Are you using older version than python 3.14 ?

[peerDE]

As for me, I'm on:

$ cat /etc/os-release
PRETTY_NAME="Ubuntu 24.04.5 LTS"

and

$ python3
Python 3.12.3 (main, Aug 31 2026, 10:18:26) [GCC 13.3.0] on linux

So that's a yes.

The "Requirements" in pilot's Readme.md ask vor "Python 3.11+", so from that point of view it "should" be fine.

[ai-sadhu]

On sys level i have similar config as @peerDE but Pilot will use Python from the bench evn right ? :

frappe@test-pilot:~/pilot/benches/prod-bench/env\$ ./bin/python --version
Python 3.14.7

frappe@test-pilot:~/pilot/benches/prod-bench/env\$ cat pyvenv.cfg
home = /home/frappe/.local/share/uv/python/cpython-3.14-linux-x86_64-gnu/bin
implementation = CPython
uv = 0.12.10
version_info = 3.14
include-system-site-packages = false

[tanmoysrt]

As per the traceback, It looks like the code validator falling back to system python in so,e case.
We will check.

[peerDE]

Now the Server is on Pilot v.0.0.38,

and in the meantime, a new Frappe Framework version was tagged:

[ v16.34.0](https://github.com/frappe/frappe/tree/v16.34.0)
https://github.com/frappe/frappe/commit/c1f1e8ec3708750d7254f7f99d869ffb9886f19f

and is supposed to be upgraded to in Pilot:

Updates
frappe 5cba016e86 -> c1f1e8ec37

It still doesn't work and produces the same error as before (e.g. upgrading 5cba016e86 -> 988e54f3c4):

Updating frappe...
Validating frappe...
Error: 'frappe' has Python syntax errors:
  frappe/model/delete_doc.py: line 152: multiple exception types must be parenthesized
  frappe/database/query.py: line 87: multiple exception types must be parenthesized
Error: 1

[peerDE]

It looks like the code validator falling back to system python in so,e case.

Looking around for you I found:

1. some paths:

peer@bv-dev:~/pilot$ echo $PATH
/home/peer/pilot/bin:/home/peer/.local/bin:/home/peer/pilot/bin:/home/peer/.nvm/versions/node/v24.20.0/bin:/home/peer/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin
peer@bv-dev:~/pilot$ cd benches/
peer@bv-dev:~/pilot/benches$ cd bv-dev/
peer@bv-dev:~/pilot/benches/bv-dev$ echo $PATH
/home/peer/pilot/bin:/home/peer/.local/bin:/home/peer/pilot/bin:/home/peer/.nvm/versions/node/v24.20.0/bin:/home/peer/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin
peer@bv-dev:~/pilot/benches/bv-dev$ . env/bin/activate
(env) peer@bv-dev:~/pilot/benches/bv-dev$ echo $PATH
/home/peer/pilot/benches/bv-dev/env/bin:/home/peer/pilot/bin:/home/peer/.local/bin:/home/peer/pilot/bin:/home/peer/.nvm/versions/node/v24.20.0/bin:/home/peer/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin
(env) peer@bv-dev:~/pilot/benches/bv-dev$ sudo echo $PATH
[sudo] password for peer:
/home/peer/pilot/benches/bv-dev/env/bin:/home/peer/pilot/bin:/home/peer/.local/bin:/home/peer/pilot/bin:/home/peer/.nvm/versions/node/v24.20.0/bin:/home/peer/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin

2. some python versions:

(env) peer@bv-dev:~/pilot/benches/bv-dev$ python --version
Python 3.14.6
(env) peer@bv-dev:~/pilot/benches/bv-dev$ sudo python --version
Python 3.12.3
(env) peer@bv-dev:~/pilot/benches/bv-dev$ deactivate
peer@bv-dev:~/pilot/benches/bv-dev$ sudo python --version
Python 3.12.3
peer@bv-dev:~/pilot/benches/bv-dev$ python --version
Python 3.12.3

Is this the helpful hint?

peer@bv-dev:~$ cat /etc/os-release
PRETTY_NAME="Ubuntu 24.04.5 LTS"
NAME="Ubuntu"
VERSION_ID="24.04"
VERSION="24.04.5 LTS (Noble Numbat)"

How to work around (or correct) that?

I guess the idea is that the server remains untouched because running and administering the server itself should stay within the version framework of Ubuntu. So it might be good to run the upgrade without superuser rights but using the env with its python version in sync with Pilot's and the Framework's versionings.

[ai-sadhu]

This code need to incorporate that it should use bench sub process to validate instead of system level process right @tanmoysrt ?

[ai-sadhu]

@tanmoysrt Let me know your thoughts and I'll happy to raise PR for this.

[tanmoysrt]

@ai-sadhu

The validator should run in .admin-env 's environment. Can you look at it ?

pilot/pilot/core/app/__init__.py

Lines 357 to 361 in 093997a

	def validate(self) -> None:
	from pilot.core.app.validator import Validator
	Validator(self).validate()

If you find a fix, please raise a PR.

[ai-sadhu]

@tanmoysrt need more information
Why the validator should run in .admin-env process i think this process is for pilot stuff ?
But the bench app validator should be run using bench env right ultimately app will run with bench env?

[tanmoysrt]

@ai-sadhu You can run it at any env. Just can't run in os's default python.
In pilot, we will eventually have python 3.14 requirement and v16 and v17 stable support.

[ai-sadhu]

Sure, thank you @tanmoysrt.
For now, I will go with the bench environment.
It makes more sense to run it there since different users might have different benches with different versions.