Conversation
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| if origin in (list, tuple, set, frozenset): | ||
| item = _ts_type(args[0]) if args else "unknown" | ||
| return f"({item})[]" if " | " in item else f"{item}[]" |
There was a problem hiding this comment.
Fixed tuples are emitted as variable-length arrays using only the first element type. As a result, load_avg: tuple[float, float, float] becomes number[] instead of [number, number, number], weakening the generated contract. Preserve fixed tuple elements and add coverage for this current target.
Prompt To Fix With AI
This is a comment left during a code review.
Path: scripts/generate_ts_types.py
Line: 134-136
Comment:
**Tuple arity is lost**
Fixed tuples are emitted as variable-length arrays using only the first element type. As a result, `load_avg: tuple[float, float, float]` becomes `number[]` instead of `[number, number, number]`, weakening the generated contract. Preserve fixed tuple elements and add coverage for this current target.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.| // The report the site-storage timer refreshes; measuring again is a task. | ||
|
|
||
| // The report the site-storage timer refreshes; measuring again is a task. |
There was a problem hiding this comment.
The site-storage comment appears twice. Remove the duplicate to satisfy the repository requirement that comments remain terse and non-redundant before merging.
| // The report the site-storage timer refreshes; measuring again is a task. | |
| // The report the site-storage timer refreshes; measuring again is a task. | |
| // The report the site-storage timer refreshes; measuring again is a task. |
Context Used: CLAUDE.md (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: admin/frontend/dashboard/src/api/sites.ts
Line: 23-25
Comment:
**Duplicated storage comment**
The site-storage comment appears twice. Remove the duplicate to satisfy the repository requirement that comments remain terse and non-redundant before merging.
```suggestion
// The report the site-storage timer refreshes; measuring again is a task.
```
**Context Used:** CLAUDE.md ([source](https://github.com/frappe/pilot/blob/main/CLAUDE.md))
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
1 participant
No description provided.