Skip to content

ISSUE-78: Updates justinrainbow/json-schema to >=6.6 & fixes test#79

Open
DiegoPino wants to merge 6 commits into
frictionlessdata:mainfrom
DiegoPino:ISSUE-78
Open

ISSUE-78: Updates justinrainbow/json-schema to >=6.6 & fixes test#79
DiegoPino wants to merge 6 commits into
frictionlessdata:mainfrom
DiegoPino:ISSUE-78

Conversation

@DiegoPino

@DiegoPino DiegoPino commented Jan 9, 2026

Copy link
Copy Markdown

Overview

See #78

Updates justinrainbow/json-schema and fixes test that depends on returned array from the error bag object on validation error (see \JsonSchema\Entity\ErrorBag::addError)
Also the phpunit schema was behind, this brings it up to 9.3

Schema Validator descriptor and error properties moved from private to protected. frictionlessdata/datapackage-php extends that class and needs access to those properties. If a better solution is to access plain accessors (e.g current errors accessor does internal revalidation so not suited for directly accessing already validated data), can do that too.


Please preserve this line to notify @courtney-miles (lead of this repository)

See \JsonSchema\Entity\ErrorBag::addError, constraint errors are an array and hold all the details inside that key, format top key is gone
@DiegoPino

Copy link
Copy Markdown
Author

Tests won't pass bc CI is set for PHP 7.1 (EOL for a while). Should I update CI & composer.json PHP to be more restrictive to PHP 8.1 > too and start targeting only 8.1+ ?

@DiegoPino

Copy link
Copy Markdown
Author

@courtney-miles hi. Could you give this a look? You ok if we drop PHP 7.x ? Thanks a lot

Coveralls reporting for 8.3
Allow extending classes to access these values, can't find a rational to have these private
PHP 8 supported sin 9.3
Not sure about the <10 here?
@DiegoPino

Copy link
Copy Markdown
Author

Hi @OriHoch or @roll maybe you can chime in? Or @courtney-miles if you missed my first message? The main issue is the current justinrainbow/json-schema requirement is a blocker, even composer/composer requires a newer version. If any one has some time we would really appreciate it. Thanks!

@roll

roll commented May 5, 2026

Copy link
Copy Markdown
Member

Hi @DiegoPino,

@pdelboca might help

@pdelboca

pdelboca commented May 6, 2026

Copy link
Copy Markdown

Hello! Sorry, I'm not sure how can I help.

I have never contributed to this repository nor have familiarity with it. I would let the maintainers chip in here.

@OriHoch

OriHoch commented May 6, 2026

Copy link
Copy Markdown
Collaborator

I think it should be fine to drop support for PHP 7, can also just ignore the error on the CI for this version

@OriHoch

OriHoch commented May 6, 2026

Copy link
Copy Markdown
Collaborator

if @courtney-miles is not available maybe we can add @DiegoPino to maintainers of this repo.. @roll

@DiegoPino

DiegoPino commented May 6, 2026

Copy link
Copy Markdown
Author

@roll @OriHoch happy to step up and maintain this repo if @courtney-miles can't right now. Don't want to step on anyone , though. We have dependencies on frictionless data package libraries and release twice a year, so it's in our wheelhouse.
Just let me know. Happy to drop PHP 7.x and roll a release too. Thanks everyone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants