Skip to content

SQL - #270

Merged
TeunHuijben merged 28 commits into
mainfrom
sql
Sep 10, 2026
Merged

SQL#270
TeunHuijben merged 28 commits into
mainfrom
sql

Conversation

@TeunHuijben

@TeunHuijben TeunHuijben commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Apart from a long list of tracksdata changes that were necessary, because it secretly handled the SQL backend differently from the in memory backends, on the funtracks side, we only need a few changes:

  • t node attribute is not mutable, so remove from revive_attrs in DeleteNode
  • Tracks.add_feature acts on graph_full
  • give the td_utils the option to pick a backend
  • a temporary tracksdata pin to the graph-views branch, until it gets merged + released

@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 93.95%. Comparing base (8ad0413) to head (e9f9d69).

Files with missing lines Patch % Lines
src/funtracks/utils/tracksdata_utils.py 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
- Coverage   93.96%   93.95%   -0.02%     
==========================================
  Files          60       60              
  Lines        3582     3589       +7     
==========================================
+ Hits         3366     3372       +6     
- Misses        216      217       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TeunHuijben
TeunHuijben marked this pull request as ready for review August 10, 2026 17:53
@TeunHuijben

Copy link
Copy Markdown
Collaborator Author

Updates:

  • funtracks is now fully compatible with two backends (memory and sql), where the default graph backend is memory (tracksdata's IndexedRXGraph).
  • all tests run over both backends (a fixture in conftest.py ensures this)

TeunHuijben and others added 9 commits September 1, 2026 11:25
* [pre-commit.ci] pre-commit autoupdate

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.16.4 → v0.16.5](astral-sh/ruff-pre-commit@v0.16.4...v0.16.5)
- [github.com/adhtruong/mirrors-typos: v1.49.0 → v1.50.0](adhtruong/mirrors-typos@v1.49.0...v1.50.0)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Teun Huijben <45037215+TeunHuijben@users.noreply.github.com>

@cmalinmayor cmalinmayor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering about the tempdir db location, since if you close the app and wait, it goes away? Also, how do we re-open an existing sql graph?

Otherwise looks great! You can merge after you decide where to save, I trust your judgement. 🎉

Comment thread src/funtracks/utils/tracksdata_utils.py
Comment thread tests/conftest.py
Comment thread pyproject.toml Outdated
@TeunHuijben

Copy link
Copy Markdown
Collaborator Author

Regarding tmpdir, when a database path is provided, the db is saved there and persists. This is what napari_track_edit should and will do

@TeunHuijben TeunHuijben added blocked PR blocked by something else and removed ready for initial review PR ready for first review labels Sep 3, 2026
@TeunHuijben

Copy link
Copy Markdown
Collaborator Author

Currently blocked 🔴 by royerlab/tracksdata#325

@TeunHuijben TeunHuijben removed the blocked PR blocked by something else label Sep 10, 2026
@TeunHuijben
TeunHuijben merged commit 1de5412 into main Sep 10, 2026
12 checks passed
@TeunHuijben
TeunHuijben deleted the sql branch September 10, 2026 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants