ensure_track_features didn't check lineage_id - #293
Open
TeunHuijben wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #293 +/- ##
=======================================
Coverage 93.95% 93.95%
=======================================
Files 60 60
Lines 3589 3592 +3
=======================================
+ Hits 3372 3375 +3
Misses 217 217 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_ensure_track_featureschecked for the "not computed" -1 sentinel on thetracklet column only. A graph whose
track_idcolumn is filled but whoselineage_idcolumn is still all -1 (e.g. a writer that populates one but notthe other) took the "already exists, just activate it" path, so -1 was served
as a real lineage id.
_has_uncomputed_track_idsnow takes both track-id keys and returns True ifeither existing column holds -1. Missing columns are still ignored, so they get
computed from scratch as before. A sentinel in either column recomputes both,
since
TrackAnnotatorderives tracklet and lineage ids together.Adds
test_recompute_lineage_ids_when_only_lineage_sentinel_present, whichfails on main with
assert -1 not in [-1, -1, -1, -1, -1, -1]on both thememory and sql backends.