fix: update report merging logic to handle non-unique method names - #89
Open
tlambert03 wants to merge 1 commit into
Open
tlambert03 wants to merge 1 commit into
tlambert03 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report.from_directorycollects reports in a dict keyed by the name stored inside each JSON file.run_evaluation.pystores every method's report under the same name (default_report), so with the documented layouteach file overwrites the previous one and
merge_reportsis handed a single report. The result is one method's report, not the per-sample best across methods (with no error). This means the per-image choice between DiscriminativeIG and Discriminative DeepLift described in the paper never happens.
Checklist