[question] spdlog v2.x status

[jan-moravec]

Hello, I like the changes in v2.x branch and I would like to use it in my project. I'm just worried if it's stable and well tested as the v1.x branch, since there is no release yet.

I guess my question is whether it is recommended using the v2.x and if there is release planned soon.

Thanks.

[gabime]

Well it passes all the tests, so it seems ok. But, it is wip and API will probably change. There is no release date yet.

Which changes in particular are you interested in ?

[jan-moravec]

I like logs in JSON format with custom properties, so I wrote a wrapper around spdlog.

Here is example of log line:

{"timestamp":"2025-01-10T08:56:33.930+01:00","logger":"HFApi","level":"debug","process":8353,"thread":8353,"errorCode":0,"function":"HFParseResultInt","message":"Exit: HFParseResultInt(value=3) -> 0 [HFERROR_OK]"}

Here is a little code snippet:

class JsonLogger
{
public:
    explicit JsonLogger(std::shared_ptr<spdlog::logger> &&logger) : mLogger(std::move(logger))
    {
    }

    using Level = spdlog::level;
    template <typename... Args> using format_string_t = fmt::format_string<Args...>;

    template <typename... Args> void Info(const JsonProperties &props, format_string_t<Args...> fmt, Args &&...args)
    {
        Log(Level::info, props, fmt, std::forward<Args>(args)...);
    }

private:
    template <typename... Args>
    void Log(Level lvl, const JsonProperties &props, format_string_t<Args...> fmt, Args &&...args)
    {
        if (!mLogger->should_log(lvl))
        {
            return;
        }

        Log(lvl, props, fmt::format(fmt, std::forward<Args>(args)...));
    }

    void Log(Level lvl, const JsonProperties &props, std::string &&msg);
    {
        mLogger->log(
            lvl, props.ToString() + R"(,"message":)" + nlohmann::json(std::move(msg)).dump()
        );
    }

    std::shared_ptr<spdlog::logger> mLogger;
};

I found it easier to use the v2.x, I remember for exmaple that the check !mLogger->should_log(lvl) was not as easy in the version v1.x.

[HaoQChen]

What is the difference between v1.x and v2.x? I can't find a doc to indicate that

[tt4g]

@HaoQChen See #3307 (comment)

[jan-moravec]

Hello, sorry for opening this again. I wonder if the v2.x is going to be updated, or is it basically dead? The branch is almost a year behind master.

Thank you.