fix(charts): grant the operator the RBAC its own feature flags need - #36
Merged
Merged
Conversation
Enabling a feature without its permissions left ingress-mode and the
east-west producers silently non-functional on a default install. Gate
each ClusterRole rule on the same value that turns the feature on, so
the flag and the grant cannot drift apart:
- ingresses/status, needed by --publish-status-address
- Gateway API read + status, behind a new operator.gatewayAPI value
that also drives the --gateway-api flag
- pods for IdentityProducer, namespaces/networkpolicies for
EdgeProducer
Gateway API stays opt-in because its CRDs are not present on every
cluster and an unconditional grant misleads an RBAC audit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling an operator feature via values did not grant the permissions that
feature needs, so the east-west producers came up silently non-functional on a
default install — the controller starts, the list/watch is forbidden, and it
reconciles nothing.
Each new ClusterRole rule is gated on the same value that turns the feature
on, so the flag and the grant cannot drift apart.
synapse-operator (1.5.1 → 1.6.0)
ingresses/status(get/update/patch) —--publish-status-addresswrites.status.loadBalancer.ingress; without it the write is forbidden andkubectl get ingressnever shows an address.operator.gatewayAPIvalue drives both the--gateway-apiflag and itsGateway API RBAC (read + status on gatewayclasses/gateways/httproutes).
synapse-stack (0.9.2 → 0.10.0)
operator.ingress.gatewayAPI, mirroring the standalone chart. Gated onand ingress.enabled gatewayAPI, since--gateway-apiis only passed to theingress-mode Deployment.
podsfor IdentityProducer;namespaces+networkpoliciesforEdgeProducer, gated on
identityProducer.enabled/edgeProducer.enabled.Gateway API stays opt-in and off by default: its CRDs are not present on every
cluster, and an unconditional grant is misleading in an RBAC audit.
Notes
--gateway-apiand--publish-status-addressexist in that release, so nochart passes a flag its pinned image would reject.
ingresses/ingressclasses/ingresses/statusunconditionally, so only the genuinely-new rules are addedthere rather than duplicating those.
Testing
helm lintpasses on both charts.helm templatewithgatewayAPI=truerenders the--gateway-apiarg andthe Gateway API rules; at default values both are absent from the output.