ref(install): Read the JS SDK loader registry with json.tool instead of cat - #4540
Merged
Merged
Conversation
… cat The sentry image is moving to a distroless base without coreutils. python3 isn't a sentry subcommand, so the entrypoint execs it directly, just like cat.
Coverage Results 📊✅ 22 passed | Total: 22 | Pass Rate: 100% | Execution Time: 10m 51s 📊 Comparison with Base Branch
✨ Test counts unchanged from base. All tests are passing successfully. ✅ Patch coverage is 100.00% (no changed executable lines found; target 50%). Coverage diff@@ Coverage Diff @@
## master #4540 +/-##
==========================================
Coverage 95.54% 95.54% —%
==========================================
Files 5 5 —
Tracked lines 336 336 —
Branches 0 0 —
==========================================
Hits 321 321 —
Misses 15 15 —
Partials 0 0 —Generated by Coverage Action |
oioki
marked this pull request as ready for review
September 30, 2026 09:45
aldy505
approved these changes
Sep 30, 2026
BYK
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup-js-sdk-assets.shread_registry.jsonfrom thewebcontainer withcat. Usepython3 -m json.toolinstead: the sentry image is moving to a distroless base without coreutils. The file is only consumed byjq, andjson.toolre-emits the same JSON (verified: identical parsed content and extracted SDK versions).python3isn't a sentry subcommand, so the entrypoint execs it directly, likecat.Covered by
_unit-test/js-sdk-assets-test.sh.Prep for moving the sentry image to a distroless base.