Skip to content

ref(install): Read the JS SDK loader registry with json.tool instead of cat - #4540

Merged
BYK merged 3 commits into
masterfrom
alextarasov/js-sdk-assets-without-cat
Sep 30, 2026
Merged

BYK merged 3 commits into
masterfrom
alextarasov/js-sdk-assets-without-cat

Conversation

@oioki

@oioki oioki commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

setup-js-sdk-assets.sh read _registry.json from the web container with cat. Use python3 -m json.tool instead: the sentry image is moving to a distroless base without coreutils. The file is only consumed by jq, and json.tool re-emits the same JSON (verified: identical parsed content and extracted SDK versions). python3 isn't a sentry subcommand, so the entrypoint execs it directly, like cat.

Covered by _unit-test/js-sdk-assets-test.sh.

Prep for moving the sentry image to a distroless base.

… cat

The sentry image is moving to a distroless base without coreutils. python3 isn't a sentry subcommand, so the entrypoint execs it directly, just like cat.
@oioki oioki changed the title ref(install): Read the JS SDK loader registry with python3 instead of cat ref(install): Read the JS SDK loader registry with json.tool instead of cat Sep 30, 2026
@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Coverage Results 📊

✅ 22 passed | Total: 22 | Pass Rate: 100% | Execution Time: 10m 51s

📊 Comparison with Base Branch

Metric Change
Total Tests —
Passed Tests —
Failed Tests —
Skipped Tests —

✨ Test counts unchanged from base.

All tests are passing successfully.

✅ Patch coverage is 100.00% (no changed executable lines found; target 50%).
Project statement coverage is 95.54% (unchanged from base (49e367f) to head (9a85fcc)).

Coverage diff
@@            Coverage Diff             @@
##        master     #4540       +/-##
==========================================
  Coverage    95.54%    95.54%        —%
==========================================
  Files            5         5         —
  Tracked lines       336       336         —
  Branches         0         0         —
==========================================
  Hits           321       321         —
  Misses          15        15         —
  Partials         0         0         —

Generated by Coverage Action

@oioki
oioki requested review from aldy505 and aminvakil September 30, 2026 09:43
@oioki
oioki marked this pull request as ready for review September 30, 2026 09:45
@BYK
BYK merged commit 68a830f into master Sep 30, 2026
24 checks passed
@BYK
BYK deleted the alextarasov/js-sdk-assets-without-cat branch September 30, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants