Repository navigation
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Fixes
🤖 This preview updates automatically when you update the PR. |
Run Android example and integration jobs on stable. Keep beta coverage for the remaining platforms. Co-Authored-By: Codex <noreply@openai.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v9 #4096 +/- ##
==========================================
+ Coverage 88.17% 92.46% +4.29%
==========================================
Files 347 114 -233
Lines 12955 4434 -8521
==========================================
- Hits 11423 4100 -7323
+ Misses 1532 334 -1198
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Drain queued native updates before fallback calls or replacement workers. Propagate deferred envelope completion and preserve accepted operations when close overlaps worker retirement. Drive integration lifecycle changes through the platform channel. Refs #4092 Co-Authored-By: Codex <noreply@openai.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Backport #4095 to
v9, based on9.30.1. Stop the Android core worker on Flutterdetached, restart it onresumedfor retained engines, and replace itscloseOnOwnerExit()registration.Drain queued native operations before caller-isolate fallback or replacement startup, preserving user/context update ordering. Preserve calls accepted before close and propagate delayed envelope submission through the native adapter. The backport retains v9's envelope and JNI APIs. Android beta example-build and integration jobs are excluded; other beta platforms remain enabled.
💡 Motivation and Context
Refs #4092 and #4095.
This is a best-effort mitigation, not a confirmed fix for the Vulkan crash. Lifecycle delivery and worker exit before native engine teardown are not guaranteed. Hosts that never deliver
detachedcan retain their workers after owner exit. The source PR's Vulkan comparison did not reproduce the original abort, and busy workers could outlive teardown; crash prevention on affected physical hardware remains unproven.💚 How did you test it?
📝 Checklist