fix(explore): Fix chart resizing on browser window change - #102876
Merged
gggritso merged 1 commit intoNov 6, 2025
Merged
Conversation
This has a bug fix that affects our resizing behaviour.
github-actions
Bot
added
the
Scope: Frontend
scttcper
approved these changes
Nov 6, 2025
billyvg
approved these changes
Nov 6, 2025
gggritso
deleted the
georgegritsouk/dain-971-explore-charts-fail-to-resize-on-browser-window-change
branch
November 6, 2025 17:27
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
There's a bug in Explore charts, where the chart doesn't resize correctly when the browser size changes. This bug is caused by a wacky race condition in `echarts-for-react`, which was fixed in hustcc/echarts-for-react#613 by yours truly, and made its way into 3.0.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a bug in Explore charts, where the chart doesn't resize correctly when the browser size changes. This bug is caused by a wacky race condition in
echarts-for-react, which was fixed in hustcc/echarts-for-react#613 by yours truly, and made its way into 3.0.5