Enable check_md5 argument for AWS#159
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR appears to add optional MD5 integrity verification for AWS S3 localizations (via a check_md5 extra arg), along with a patch version bump.
Changes:
- Bump package version from
0.17.0to0.17.1. - Add
check_md5handling to the AWS S3 file handler, including multipart-aware hashing logic. - Refactor the AWS S3 localization command construction to build a command list before joining.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
canine/orchestrator.py |
Patch version bump for the release containing the new AWS check_md5 behavior. |
canine/localization/file_handlers.py |
Adds check_md5 flag support for S3 downloads and attempts multipart-aware MD5 verification. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
SamWisedev
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.