Implement blink attribute for text#11875
Open
brianc442 wants to merge 1 commit intoghostty-org:mainfrom
Open
Conversation
…nderer thread. Text blink is toggled on the same timer as the existing cursor blink. All foreground rendering (glyphs, underline, overline, strikethrough) is skipped during the hidden phase, matching xterm behavior.
Member
|
Is there a reason the skip logic isn't implemented the same way as it is for the invisible flag? |
Author
Yes - I initially used the same if style.flags.blink: continue logic but when I tested, the text didn't actually blink. When I looked into why, it has to do with an underlying difference between invisible text and blinking text. Invisible text is explicitly skipped by the shaper in run.zig lines 63-67 since there are no glyphs rendered. The same is not true of blinking text so I wrapped each style individually instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #7703
Add text_blink_visible flag to renderer thread. Text blink is toggled on the same timer as the existing cursor blink. All foreground rendering (glyphs, underline, overline, strikethrough) is skipped during the hidden phase, matching xterm behavior.
Claude Code was used to locate where changes were needed in the codebase, but the changes were written myself.