widget: allow selection to clear at edge of textbox with arrow key - #178
Open
samsrdc wants to merge 1 commit into
Open
widget: allow selection to clear at edge of textbox with arrow key#178samsrdc wants to merge 1 commit into
samsrdc wants to merge 1 commit into
Conversation
Author
|
Just noting this came from an original patch here https://lists.sr.ht/~eliasnaur/gio-patches/patches/70445 but moving forward I think Github is easier for me. |
Contributor
|
It seems your commit is missing the "Signed-off-by". Use git commit -s to add it. |
samsrdc
force-pushed
the
fix-edge-text-sel
branch
from
August 14, 2026 01:57
5907c07 to
43f5dd9
Compare
Author
|
Should be done now, although I used git commit --amend -S Let me know if there is an issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes editor behaviour to allow selection to be cleared when either:
a) The selection extends to the first character in the editor, and the user presses the left/up arrow keys.
b) The selection extends to the last character in the editor, and the user presses the right/down arrow keys.
Added ModCtrl to the filters as it should also take effect on any key modifier.
The previous behaviour without this patch is that when the selection extends to the start/end, the user cannot clear the selection when pressing an arrow key in the direction of the start/end.