fix(notes): delete legacy three-level fanout paths before writes#1553
Open
jiangyq9 wants to merge 3 commits into
Open
fix(notes): delete legacy three-level fanout paths before writes#1553jiangyq9 wants to merge 3 commits into
jiangyq9 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
notes_add_batchandnotes_add_blob_batchrewrite notes into the canonical two-level fanout path, but the delete step only covered the flat path and the current two-level fanout path. Repositories that already contain an older three-level fanout note path can keep that stale note alongside the rewritten note.That leaves two note entries for the same annotated object.
git notes showmay concatenate both note payloads, which breaks JSON deserialization and can make downstream stats treat commits as untracked.Root cause
The note rewrite path removed:
<object-sha><aa>/<rest-of-object-sha>but did not remove legacy three-level paths:
<aa>/<bb>/<rest-of-object-sha>Change
notes_add_batchnotes_add_blob_batchTesting
Fixes #1517