Skip to content

Fix text margin arrays to use documented TRBL order #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guiwoda wants to merge 4 commits into
base: master
Choose a base branch
from
+24 −3
Open

Fix text margin arrays to use documented TRBL order #1475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
234c504
Fix text margin arrays to use documented TRBL order
guiwoda Aug 10, 2026
732db03
Revert package.json/lockfile changes from the test script addition.
guiwoda Aug 10, 2026
dce78ce
Remove built dist/bundle artifacts from the PR.
guiwoda Aug 10, 2026
2e9121e
Test text margin TRBL via demos instead of a standalone unit test.
guiwoda Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Unreleased

### Fixed

- Text `margin` arrays now map as documented TRBL `[top, right, bottom, left]` instead of LRBT (`lIns`/`tIns` were swapped)

## [4.0.1](https://github.com/gitbrent/PptxGenJS/releases/tag/v4.0.1) - 2025-06-25

### Fixed
Expand Down
15 changes: 15 additions & 0 deletions demos/modules/demo_text.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,20 @@ function genSlide01(pptx) {
{ x: 10, y: 2.25, w: 3.0, h: 1.0, color: "FFFFFF", fill: { color: "C00000" }, valign: "bottom", align: "right", margin: 0 }
);

// TEST-CASE: text margin arrays are TRBL [top, right, bottom, left]
// Left inset should be large here (not top). Regression: LRBT mapping swapped ends.
slide.addText("margin:[5,5,5,40]\n(left=40pt)", {
x: 10,
y: 3.35,
w: 3.0,
h: 0.9,
color: "363636",
fill: { color: "F1F1F1" },
fontSize: 12,
valign: "middle",
margin: [5, 5, 5, 40],
});

slide.addText("^ (50%/50%)", { x: "50%", y: "50%", w: 2 });

slide.addText("Plain x/y coords", { x: 10, y: 4.35, w: 3 });
Expand Down Expand Up @@ -202,6 +216,7 @@ function genSlide02(pptx) {
});

// 4: Line-Spacing (bullets)
// TEST-CASE: margin [0,0,0,10] = left 10pt (TRBL), not top
slide.addText("Line-Spacing (bullets):", { x: 7.0, y: 5.6, w: "40%", h: 0.3, margin: 0, color: pptx.colors.ACCENT1 });
slide.addText([{ text: "lineSpacing\n35pt", options: { fontSize: 24, bullet: true, color: "99ABCC", lineSpacing: 35 } }], {
x: 7.0,
Expand Down
6 changes: 3 additions & 3 deletions src/gen-xml.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,13 +391,13 @@ function slideObjectToXml (slide: PresSlide | SlideLayout): string {
// Lines can have zero cy, but text should not
if (!slideItemObj.options.line && cy === 0) cy = EMU * 0.3

// Margin/Padding/Inset for textboxes
// Margin/Padding/Inset for textboxes (TRBL: [top, right, bottom, left])
if (!slideItemObj.options._bodyProp) slideItemObj.options._bodyProp = {}
if (slideItemObj.options.margin && Array.isArray(slideItemObj.options.margin)) {
slideItemObj.options._bodyProp.lIns = valToPts(slideItemObj.options.margin[0] || 0)
slideItemObj.options._bodyProp.tIns = valToPts(slideItemObj.options.margin[0] || 0)
slideItemObj.options._bodyProp.rIns = valToPts(slideItemObj.options.margin[1] || 0)
slideItemObj.options._bodyProp.bIns = valToPts(slideItemObj.options.margin[2] || 0)
slideItemObj.options._bodyProp.tIns = valToPts(slideItemObj.options.margin[3] || 0)
slideItemObj.options._bodyProp.lIns = valToPts(slideItemObj.options.margin[3] || 0)
} else if (typeof slideItemObj.options.margin === 'number') {
slideItemObj.options._bodyProp.lIns = valToPts(slideItemObj.options.margin)
slideItemObj.options._bodyProp.rIns = valToPts(slideItemObj.options.margin)
Expand Down