[GHSA-97xx-95pm-5qv6] When a protocol selection parameter option disables all...#7367
Closed
tjuyuxinzhang wants to merge 1 commit intotjuyuxinzhang/advisory-improvement-7367from
Closed
Conversation
github-actions
bot
changed the base branch from
main
to
tjuyuxinzhang/advisory-improvement-7367
Contributor
|
👋 Hi @tjuyuxinzhang, I'm closing the PR because curl isn't in one of the GitHub Advisory Database's supported ecosystems and therefore can't be added to the set of reviewed advisories. We can't make any changes to advisories without reviewing them. Thank you for your interest in GHSA-97xx-95pm-5qv6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
Comments
This advisory currently lacks precise upstream version boundaries and may overgeneralize affected versions across ecosystems.
According to the official curl security advisory:
https://curl.se/docs/CVE-2024-2004.html
CVE-2024-2004 affects both curl and libcurl due to a logic flaw in protocol selection handling. When a protocol selection string disables all protocols without enabling any, the default protocol set is incorrectly retained, allowing unintended protocol usage (e.g., plaintext HTTP).
Correct upstream version information:
The vulnerability was:
This issue impacts:
It should not be represented as affecting all historical versions or unrelated packages.
Severity remains LOW as assessed by the curl security team.
The current advisory lacks precise upstream version boundaries and may incorrectly imply broader impact.
Upstream curl explicitly defines:
Some data sources incorrectly mark the vulnerability as affecting all historical versions (introduced=0), which is inaccurate.
This change aligns the advisory with the official curl security advisory and ensures correct affected version range and component scope (curl/libcurl only).