Assess only reader-visible dashboard views so the assessment completes within its budget - #12693
Merged
Merged
Conversation
…imeout Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
…ment Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Investigate and fix dashboard view assessment findings
Assess only reader-visible dashboard views so the assessment completes within its budget
Sep 18, 2026
mnkiefer
marked this pull request as ready for review
September 18, 2026 06:06
mnkiefer
approved these changes
Sep 18, 2026
Contributor
Dashboard view assessment38/43 selected views passed the informational assessment. The DOM budget is 6000 nodes per loaded view.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The daily dashboard view assessment reported
costas failed and was blocked bybrowser.newPage: Target page, context or browser has been closedafter assessing only 2.5 of 69 views.Root cause
costdeclares afull-viewlazy-list table alongside charts. The presenter's view-mode selection (data-mobile-view-mode, defaultchart) hides that table withdisplay: none, so its lazy-view skeleton keepsaria-busy="true"indefinitely and is never scrollable into view. The assessment waited on that hidden skeleton — ~30 sscrollIntoViewIfNeeded, ~30 s hydration loop, ~5 stoHaveCount(0)— about 65 s per such page. That exhausted the flat 180 s test timeout mid-cost; Playwright then closed the browser, yielding both thecosterror (locator.count: Target page ... closed) and the run-level blocker.Changes
tests/e2e/dashboard-view-assessment.mjs: newvisibleViewSelector/visibleBusyViewSelector, plusdashboardAssessmentTimeout(pageCount)(120 s startup + 20 s per view, capped at 15 min).tests/e2e/dashboard-views-live.spec.mjs: scroll and await only visible views; apply the scaled timeout. Rendered-view accounting still uses the unfiltered locator, so mode-hidden views are not reported missing..github/workflows/dashboard-views.yml: assess job timeout 20 → 30 min, so a capped run always finishes and uploads its summary.tests/unit/dashboard-view-assessment.test.mjs: coverage for the new helpers.A full local assessment of all 69 views now completes in ~2.6 min (previously 2.5 views in 3 min before blocking), with
costrendering all three of its views.