Skip to content

Assess only reader-visible dashboard views so the assessment completes within its budget - #12693

Merged
mnkiefer merged 3 commits into
mainfrom
copilot/dashboard-view-assessment
Sep 18, 2026
Merged

mnkiefer merged 3 commits into
mainfrom
copilot/dashboard-view-assessment

Conversation

Copilot AI commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

The daily dashboard view assessment reported cost as failed and was blocked by browser.newPage: Target page, context or browser has been closed after assessing only 2.5 of 69 views.

Root cause

cost declares a full-view lazy-list table alongside charts. The presenter's view-mode selection (data-mobile-view-mode, default chart) hides that table with display: none, so its lazy-view skeleton keeps aria-busy="true" indefinitely and is never scrollable into view. The assessment waited on that hidden skeleton — ~30 s scrollIntoViewIfNeeded, ~30 s hydration loop, ~5 s toHaveCount(0) — about 65 s per such page. That exhausted the flat 180 s test timeout mid-cost; Playwright then closed the browser, yielding both the cost error (locator.count: Target page ... closed) and the run-level blocker.

Changes

  • tests/e2e/dashboard-view-assessment.mjs: new visibleViewSelector / visibleBusyViewSelector, plus dashboardAssessmentTimeout(pageCount) (120 s startup + 20 s per view, capped at 15 min).
  • tests/e2e/dashboard-views-live.spec.mjs: scroll and await only visible views; apply the scaled timeout. Rendered-view accounting still uses the unfiltered locator, so mode-hidden views are not reported missing.
  • .github/workflows/dashboard-views.yml: assess job timeout 20 → 30 min, so a capped run always finishes and uploads its summary.
  • tests/unit/dashboard-view-assessment.test.mjs: coverage for the new helpers.
const visibleViews = activePage.locator(visibleViewSelector);      // [data-view-id]:visible
const busyViews = activePage.locator(visibleBusyViewSelector);     // [aria-busy="true"]:visible

A full local assessment of all 69 views now completes in ~2.6 min (previously 2.5 views in 3 min before blocking), with cost rendering all three of its views.

Copilot AI linked an issue Sep 18, 2026 that may be closed by this pull request
Copilot AI and others added 2 commits September 18, 2026 06:02
…imeout

Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
…ment

Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Copilot AI changed the title [WIP] Investigate and fix dashboard view assessment findings Assess only reader-visible dashboard views so the assessment completes within its budget Sep 18, 2026
@mnkiefer
mnkiefer marked this pull request as ready for review September 18, 2026 06:06
Copilot AI requested a review from mnkiefer September 18, 2026 06:07
@github-actions

Copy link
Copy Markdown
Contributor

Dashboard view assessment

38/43 selected views passed the informational assessment. The DOM budget is 6000 nodes per loaded view.
Ignored views: operations, readiness.

View Result DOM nodes Findings
github-api passed 1493 None
safe-output-items passed 2453 None
cost passed 4152 None
firewall passed 2995 None
mcps passed 1543 None
security passed 2224 None
organizations passed 3494 None
repositories passed 1910 None
repository-workflows passed 1422 None
repository-detail passed 1486 None
workflow-detail passed 1475 None
workflow-runs passed 1476 None
workflow-run-cards passed 1422 None
workflow-runtime passed 1424 None
outcome-detail passed 1449 None
packages passed 1430 None
package-insights passed 1509 None
package-detail passed 1416 None
package-workflows passed 1482 None
package-issues passed 1465 None
package-pull-requests passed 1465 None
package-runs passed 1568 None
package-dispatches passed 1459 None
package-repositories passed 1466 None
package-reports passed 1475 None
workflows failed unknown 1 browser error(s)
runtime passed 1835 None
performance passed 1429 None
runs failed unknown 1 browser error(s)
safe-outputs passed 2522 None
detection passed 1514 None
dispatches passed 2369 None
experiments passed 1507 None
graders failed 6582 DOM budget exceeded: 6582/6000
evals passed 1505 None
usage failed 7363 DOM budget exceeded: 7363/6000
run-events passed 1422 None
events passed 2388 None
audit passed 1511 None
transactions passed 1580 None
engines-models passed 1477 None
operational-value passed 1430 None
findings failed 11796 DOM budget exceeded: 11796/6000
View the workflow run.

@mnkiefer
mnkiefer merged commit a861f0f into main Sep 18, 2026
11 checks passed
@mnkiefer
mnkiefer deleted the copilot/dashboard-view-assessment branch September 18, 2026 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dashboard view assessment

2 participants