fix(task): align lustre-csi-deployment expected_output with live deploy - #214
Closed
geojaz wants to merge 1 commit into
Closed
fix(task): align lustre-csi-deployment expected_output with live deploy#214geojaz wants to merge 1 commit into
geojaz wants to merge 1 commit into
Conversation
The lustre-csi-deployment task uses deployer: tofu, so the harness sets generation_only=False and the OutcomeValidity judge requires the agent to apply resources to a live cluster and confirm the apply. But its expected_output was written with the noop generate_manifest template (Expected Tool Call: generate_manifest plus a full Expected Manifest Generated block), which frames it as generation-only. That mismatch made the judge expect a live apply the criteria never described, mis-scoring the task. The task is genuinely a live deploy: it provisions a real GPU cluster and a pre-provisioned Managed Lustre instance, and objective 1 requires querying that live instance (gcloud lustre instances describe), which is impossible in a generation-only task. Rewrite expected_output to an applied-to-cluster success criterion, matching the convention used by the other tofu tasks (tasks/gcp/deploy-config and tasks/gcp/deploy-hello-app). This was the only tofu task using the generate_manifest template.
geojaz
force-pushed
the
fix/lustre-csi-task-live-deploy-expected-output
branch
from
July 20, 2026 16:26
1e2007d to
349897c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tasks/gcp/lustre-csi-deployment/task.yamlhad an inconsistency between its deployer and its expected_output, found during a verifier-coverage audit.infrastructure.deployer: tofu, so the harness setsgeneration_only=False(devops_bench/evalharness/default.py:958, wheregeneration_only = deployer == "noop").expected_outputwas written with the noop generation-only template: anExpected Tool Call: generate_manifestline plus a fullExpected Manifest Generated:YAML block.With
generation_only=False, the OutcomeValidity GEval judge does not apply the generation-only override. It requires the agent to actually apply resources to a live cluster and confirm the apply (manifest-only is graded a significant failure). The generate_manifest framing contradicted that, so the judge would expect a live apply the criteria never described, mis-scoring the task.Why this is a live-deploy task
The intent is unambiguously live-deploy, so correcting the expected_output (rather than flipping the deployer) is the minimal fix:
prebuilt/lustre-csistack,g2-standard-4node) and references a pre-provisioned Managed Lustre instance.gcloud lustre instances describe), which is impossible in a generation-only task.Flipping to
deployer: noopwould be the wrong fix: it would strip the cluster and the Lustre instance and break objective 1.Change
Rewrite
expected_outputfrom the generate_manifest template to an applied-to-cluster success criterion, matching the convention used by the other tofu tasks (tasks/gcp/deploy-config,tasks/gcp/deploy-hello-app).We are no longer generating a manifest, but the
critical requirementschecklist still verifies the substantive properties the old manifest block encoded: the Managed Lustre CSI driver, the volumeHandle format, the queried mount IP and filesystem attributes, static PV/PVC binding, the 1-GPU request, the/modelsmount, and the ClusterIP Service on port 8000. Values the prompt states are enforced; incidental reference-solution values it never states (exact storage-class name, capacity, reclaim policy, target port, replica count) are left out so a valid deployment is not failed for choosing different ones, per the repo's graded-on-outcome convention.This was the only tofu task using the generate_manifest template.
Testing
uv run pytest tests/unit/tasks/test_tasks_schema.py tests/unit/metrics/test_metrics_pipeline.py tests/unit/evalharness/test_reporter.py -q-> 67 passeduv run ruff check .-> no new findings (pre-existing errors are confined to legacydeployers/andpkg/)deployerunchanged (tofu).