fix(retention): return 404 for missing policies

[rkthtrifork]

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Return 404 Not Found when requesting a retention policy that does not exist.

Previously, the retention DAO returned Beego's raw orm.ErrNoRows, and the retention manager converted it into an untyped error. Harbor's shared HTTP error responder therefore classified the error as unknown and returned 500 Internal Server Error.

This change:

• Wraps missing retention policies with Harbor's standard NOT_FOUND error using orm.WrapNotFoundError.
• Propagates the typed error through the retention manager.
• Documents the 404 response in the API specification.
• Adds DAO and manager assertions covering the error classification and message.

This matches the existing behavior and implementation used by other ID-based resources such as robots and quotas.

Issue being fixed

No existing issue.

Please indicate you've done the following:

• Well Written Title and Summary of the PR
• Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
• Accepted the DCO. Commits without the DCO will delay acceptance.
• Made sure tests are passing and test coverage is added if needed.
• Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

[Copilot]

Pull request overview

Updates retention-policy lookup failures to return Harbor’s typed 404 Not Found response.

Changes:

• Wraps missing DAO records as not-found errors.
• Propagates and tests typed errors.
• Documents the API’s 404 response.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/pkg/retention/manager.go	Propagates typed DAO errors.
src/pkg/retention/manager_test.go	Verifies not-found classification and message.
src/pkg/retention/dao/retention.go	Wraps missing policies as not-found errors.
src/pkg/retention/dao/retention_test.go	Tests DAO error behavior.
api/v2.0/swagger.yaml	Documents the GET 404 response.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.39%. Comparing base (89dbf8f) to head (2d90c2e).
⚠️ Report is 106 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #23592      +/-   ##
==========================================
+ Coverage   66.38%   66.39%   +0.01%     
==========================================
  Files        1073     1073              
  Lines      117757   117770      +13     
  Branches     2965     2965              
==========================================
+ Hits        78170    78192      +22     
+ Misses      35284    35275       -9     
  Partials     4303     4303              

Flag	Coverage Δ
unittests	66.39% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/pkg/retention/dao/retention.go	60.00% <100.00%> (ø)
src/pkg/retention/manager.go	75.47% <ø> (+0.92%)	⬆️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[wy65701436]

The 404 response is added only to getRetention, but this change affects more endpoints than that.

• updateRetention — controller UpdateRetention calls manager.GetPolicy
• deleteRetention — DeleteRetention calls manager.GetPolicy

I am not go through them all, but please. thanks.

[rkthtrifork]

Sorry it took a while for me to get back. I believe i have fixed what you asked about.

[github-actions]

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

[rkthtrifork]

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

This PR is not stale