fix(scanner): optimize removal of immutable scanners with bulk deletion - #24023
Open
vishalmore90 wants to merge 1 commit into
Open
vishalmore90 wants to merge 1 commit into
vishalmore90 wants to merge 1 commit into
Conversation
Signed-off-by: vishal <httpsvishal07@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comprehensive Summary of your change
This PR resolves an N+1 query performance issue in the
RemoveImmutableScannersinitialization step.Previously, when clearing out old immutable scanners,
RemoveImmutableScannersretrieved all relevant scanner registrations from the database and executed an individualDELETEquery for each scanner in a loop. For setups with multiple scanners being cycled or cleared out, this generated unnecessary DB traffic and latency.This PR implements a bulk-deletion method (
DeleteRegistrations) in the scanner data access object (dao/scanner/registration.go), wires it through the scannerManagerinterface asDeleteBy, and updatesRemoveImmutableScannersininit.goto use this new method. It completely replaces the N+1DELETEloop with a single bulk query, resolving the documentedTODO. Unit tests and mocks have been appropriately updated and verified.Issue being fixed
Fixes #24022
Please indicate you've done the following: